Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2026-07-21 23:20:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

plugin/forward: Fix incorrect retry of local DNS message serialization failures (#8313)

Browse Source 
This PR fixes the forward plugin incorrectly retrying deterministic
local DNS message serialization failures as if they were upstream transport errors.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This commit is contained in:
Yong Tang
2026-07-19 03:48:00 -07:00
committed by GitHub
parent 57f73b4a43
commit 96ec17d5c6
3 changed files with 70 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugin/forward/forward.go
View File

@@ -206,6 +206,10 @@ func (f *Forward) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg
upstreamErr = err
if err != nil {
if errors.Is(err, proxyPkg.ErrInvalidRequest) {
return dns.RcodeFormatError, err
}
// Kick off health check to see if *our* upstream is broken.
if f.maxfails != 0 {
proxy.Healthcheck()