Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-03 02:33:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

clouddns,route53: fix lingering goroutines after restart (#4096)

Browse Source 
Stop the context so the refresh loop terminates on restart.

Fixes: #3815

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben
2020-08-31 15:39:01 +02:00
committed by GitHub
parent c126e7fc11
commit 9e4a177d9f
3 changed files with 22 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugin/route53/route53_test.go
View File

@@ -81,7 +81,7 @@ func TestRoute53(t *testing.T) {
r, err := New(ctx, fakeRoute53{}, map[string][]string{"bad.": {"0987654321"}}, time.Minute)
if err != nil {
t.Fatalf("Failed to create Route53: %v", err)
t.Fatalf("Failed to create route53: %v", err)
}
if err = r.Run(ctx); err == nil {
t.Fatalf("Expected errors for zone bad.")
@@ -89,7 +89,7 @@ func TestRoute53(t *testing.T) {
r, err = New(ctx, fakeRoute53{}, map[string][]string{"org.": {"1357986420", "1234567890"}, "gov.": {"Z098765432", "1234567890"}}, 90*time.Second)
if err != nil {
t.Fatalf("Failed to create Route53: %v", err)
t.Fatalf("Failed to create route53: %v", err)
}
r.Fall = fall.Zero
r.Fall.SetZonesFromArgs([]string{"gov."})
@@ -117,7 +117,7 @@ func TestRoute53(t *testing.T) {
})
err = r.Run(ctx)
if err != nil {
t.Fatalf("Failed to initialize Route53: %v", err)
t.Fatalf("Failed to initialize route53: %v", err)
}
tests := []struct {