Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-28 00:34:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

fuzz: fix rewrite crash by fixing fuzz/do.go (#3178)

Browse Source 
Automatically submitted.
This commit is contained in:
Miek Gieben
2019-08-22 18:49:22 +00:00
committed by corbot[bot]
parent f8e0ae6330
commit 9f49d694e9
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
plugin/pkg/fuzz/do.go
View File

@@ -13,15 +13,19 @@ import (
// Do will fuzz p - used by gofuzz. See Makefile.fuzz for comments and context. // Do will fuzz p - used by gofuzz. See Makefile.fuzz for comments and context.
func Do(p plugin.Handler, data []byte) int { func Do(p plugin.Handler, data []byte) int {
ctx := context.TODO() ctx := context.TODO()
ret := 1
r := new(dns.Msg) r := new(dns.Msg)
if err := r.Unpack(data); err != nil { if err := r.Unpack(data); err != nil {
ret = 0 return 0 // plugin will never be called when this happens.
}
// If the data unpack into a dns msg, but does not have a proper question section discard it.
// The server parts make sure this is true before calling the plugins; mimic this behavior.
if len(r.Question) == 0 {
return 0
} }
if _, err := p.ServeDNS(ctx, &test.ResponseWriter{}, r); err != nil { if _, err := p.ServeDNS(ctx, &test.ResponseWriter{}, r); err != nil {
ret = 1 return 1
} }
return ret return 0
} }