mirror of
https://github.com/coredns/coredns.git
synced 2025-10-28 00:34:24 -04:00
Fixes races in test and klog (#3079)
Various fixes to make things less flaky: * kubernetes: put klog.SetOutput in the setup function, not in the init function to see if that helps * file: make z.Expired a boolean instead of a pointer to a boolean * test: fix TestSecondaryZoneTransfer test, which wasn't actually testing in the right way. It's more right now, but may still be racy (race introduced because a file's lazy loading of zones) Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
@@ -125,7 +125,6 @@ func TestTransferIn(t *testing.T) {
|
||||
defer s.Shutdown()
|
||||
|
||||
z := new(Zone)
|
||||
z.Expired = new(bool)
|
||||
z.origin = testZone
|
||||
z.TransferFrom = []string{addrstr}
|
||||
|
||||
@@ -140,7 +139,6 @@ func TestTransferIn(t *testing.T) {
|
||||
|
||||
func TestIsNotify(t *testing.T) {
|
||||
z := new(Zone)
|
||||
z.Expired = new(bool)
|
||||
z.origin = testZone
|
||||
state := newRequest(testZone, dns.TypeSOA)
|
||||
// need to set opcode
|
||||
|
||||
Reference in New Issue
Block a user