mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-30 17:53:21 -04:00 
			
		
		
		
	plugin/dnstap: remove custom encoder (#4242)
* plugin/dnstap: remove encoder*.go Those files reimplemented parts of the dnstap spec, we can just use the dnstap functions for that. This leaves all the queuing that is enabled and drops messages if the dnstap reader can't keep up. In the new code flush() would never return an error (at least I couldn't make it do so), so the reconnect functionally is moved to kick off when we get write errors. Some smaller cosmetic changes as well, `d.socket` is now `proto`, which makes the dial() function smaller. Total testing time is now <1s (which was the impetus to look into this plugin *again*). See #4238 The buffered channel needs to be sized correctly, as we may need to do some queing if the dnstap reader can't keep up. Signed-off-by: Miek Gieben <miek@miek.nl> * add missing file Signed-off-by: Miek Gieben <miek@miek.nl> * update doc on queing Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
		| @@ -13,8 +13,8 @@ import ( | ||||
| func init() { plugin.Register("dnstap", setup) } | ||||
|  | ||||
| type config struct { | ||||
| 	proto  string | ||||
| 	target string | ||||
| 	socket bool | ||||
| 	full   bool | ||||
| } | ||||
|  | ||||
| @@ -32,10 +32,10 @@ func parseConfig(d *caddy.Controller) (c config, err error) { | ||||
| 			return c, d.ArgErr() | ||||
| 		} | ||||
| 		c.target = servers[0] | ||||
| 		c.proto = "tcp" | ||||
| 	} else { | ||||
| 		// default to UNIX socket | ||||
| 		c.target = strings.TrimPrefix(c.target, "unix://") | ||||
| 		c.socket = true | ||||
| 		c.proto = "unix" | ||||
| 	} | ||||
|  | ||||
| 	c.full = d.NextArg() && d.Val() == "full" | ||||
| @@ -49,7 +49,7 @@ func setup(c *caddy.Controller) error { | ||||
| 		return plugin.Error("dnstap", err) | ||||
| 	} | ||||
|  | ||||
| 	dio := dnstapio.New(conf.target, conf.socket) | ||||
| 	dio := dnstapio.New(conf.proto, conf.target) | ||||
| 	dnstap := Dnstap{io: dio, IncludeRawMessage: conf.full} | ||||
|  | ||||
| 	c.OnStartup(func() error { | ||||
|   | ||||
		Reference in New Issue
	
	Block a user