Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-28 16:54:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

[plugin/rewrite] Refactor to satisfy security scan (#5214)

Browse Source 
this PR re-arrange the logic to avoid a false positive DAST scan.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This commit is contained in:
Yong Tang
2022-03-01 11:33:52 -08:00
committed by GitHub
parent 6c26446bb7
commit a1429e1445
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
plugin/rewrite/name.go
View File

@@ -298,18 +298,19 @@ func newNameRule(nextAction string, args ...string) (Rule, error) {
return nil, fmt.Errorf("too few arguments for a name rule") return nil, fmt.Errorf("too few arguments for a name rule")
} }
if len(args) == 2 { if len(args) == 2 {
matchType = "exact" matchType = ExactMatch
rewriteQuestionFrom = plugin.Name(args[0]).Normalize() rewriteQuestionFrom = plugin.Name(args[0]).Normalize()
rewriteQuestionTo = plugin.Name(args[1]).Normalize() rewriteQuestionTo = plugin.Name(args[1]).Normalize()
} }
if len(args) >= 3 { if len(args) >= 3 {
matchType = strings.ToLower(args[0]) matchType = strings.ToLower(args[0])
rewriteQuestionFrom = plugin.Name(args[1]).Normalize() if matchType == RegexMatch {
rewriteQuestionTo = plugin.Name(args[2]).Normalize() rewriteQuestionFrom = args[1]
} rewriteQuestionTo = args[2]
if matchType == RegexMatch { } else {
rewriteQuestionFrom = args[1] rewriteQuestionFrom = plugin.Name(args[1]).Normalize()
rewriteQuestionTo = args[2] rewriteQuestionTo = plugin.Name(args[2]).Normalize()
}
} }
if matchType == ExactMatch || matchType == SuffixMatch { if matchType == ExactMatch || matchType == SuffixMatch {
if !hasClosingDot(rewriteQuestionFrom) { if !hasClosingDot(rewriteQuestionFrom) {