Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-27 08:14:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

plugin/ready: fix starts and restarts (#2814)

Browse Source 
Add OnRestartFailed to the ready plugin and some various cleanups.

Document slightly better how things are supposed to work with multiple
`ready`'s in the multiple Server Blocks.

All manually tested with this Corefile:
~~~
. {
    log
    ready
}

example.org {
    log
    chaos
    ready
}
~~~
And then `kill -SIGUSR1` and curling the ready endpoint. This works
well, the FailedReload is triggered by adding a syntax error in the
Corefile.

See #2659

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben
2019-06-09 08:10:15 +01:00
committed by GitHub
parent bd83f74deb
commit a1c97f82a6
4 changed files with 20 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugin/pkg/uniq/uniq.go
View File

@@ -28,7 +28,7 @@ func (u U) Unset(key string) {
delete(u.u, key)
}
// ForEach iterates for u executes f for each element that is 'todo' and sets it to 'done'.
// ForEach iterates over u and executes f for each element that is 'todo' and sets it to 'done'.
func (u U) ForEach() error {
for k, v := range u.u {
if v.state == todo {