Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-01 02:33:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

middleware/secondary: pull all zones (#834)

Browse Source 
Use the same OnStartup setup as in the file middleware. We need to copy
the variable from range, otherwise it gets overwriten in the next loop
because of the async goroutine call.

Hard to test, we have secondary_test.go which we could extend with
multiple zones for instance. For now this fix does not have an test case
with it...
This commit is contained in:
Miek Gieben
2017-08-05 01:36:11 -07:00
committed by GitHub
parent b11cf7c2bc
commit a235833be8
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
middleware/secondary/setup.go
View File

@@ -25,12 +25,13 @@ func setup(c *caddy.Controller) error {
// Add startup functions to retrieve the zone and keep it up to date. // Add startup functions to retrieve the zone and keep it up to date.
for _, n := range zones.Names { for _, n := range zones.Names {
if len(zones.Z[n].TransferFrom) > 0 { z := zones.Z[n]
if len(z.TransferFrom) > 0 {
c.OnStartup(func() error { c.OnStartup(func() error {
zones.Z[n].StartupOnce.Do(func() { z.StartupOnce.Do(func() {
zones.Z[n].TransferIn() z.TransferIn()
go func() { go func() {
zones.Z[n].Update() z.Update()
}() }()
}) })
return nil return nil