Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-31 18:23:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

plugin/rewrite: add closing dot for suffix rewrite rule (#2070)

Browse Source 
* add closing dot for suffix rewrite rule
* improve rule syntax checks

Resolves: #1881
This commit is contained in:
Paul G
2018-10-23 16:59:59 -04:00
committed by GitHub
parent e8e8187a64
commit a9ce35ae4e
4 changed files with 200 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
plugin/rewrite/name_test.go
View File

@@ -31,3 +31,58 @@ func TestRewriteIllegalName(t *testing.T) {
t.Errorf("Expected invalid name, got %s", err.Error())
}
}
func TestNewNameRule(t *testing.T) {
tests := []struct {
next string
args []string
expectedFail bool
}{
{"stop", []string{"exact", "srv3.coredns.rocks", "srv4.coredns.rocks"}, false},
{"stop", []string{"srv1.coredns.rocks", "srv2.coredns.rocks"}, false},
{"stop", []string{"suffix", "coredns.rocks", "coredns.rocks."}, false},
{"stop", []string{"suffix", "coredns.rocks.", "coredns.rocks"}, false},
{"stop", []string{"suffix", "coredns.rocks.", "coredns.rocks."}, false},
{"stop", []string{"regex", "srv1.coredns.rocks", "10"}, false},
{"stop", []string{"regex", "(.*).coredns.rocks", "10"}, false},
{"stop", []string{"regex", "(.*).coredns.rocks", "{1}.coredns.rocks"}, false},
{"stop", []string{"regex", "(.*).coredns.rocks", "{1}.{2}.coredns.rocks"}, true},
{"stop", []string{"regex", "staging.mydomain.com", "aws-loadbalancer-id.us-east-1.elb.amazonaws.com"}, false},
}
for i, tc := range tests {
failed := false
rule, err := newNameRule(tc.next, tc.args...)
if err != nil {
failed = true
}
if !failed && !tc.expectedFail {
t.Logf("Test %d: PASS, passed as expected: (%s) %s", i, tc.next, tc.args)
continue
}
if failed && tc.expectedFail {
t.Logf("Test %d: PASS, failed as expected: (%s) %s: %s", i, tc.next, tc.args, err)
continue
}
if failed && !tc.expectedFail {
t.Fatalf("Test %d: FAIL, expected fail=%t, but received fail=%t: (%s) %s, rule=%v, error=%s", i, tc.expectedFail, failed, tc.next, tc.args, rule, err)
}
t.Fatalf("Test %d: FAIL, expected fail=%t, but received fail=%t: (%s) %s, rule=%v", i, tc.expectedFail, failed, tc.next, tc.args, rule)
}
for i, tc := range tests {
failed := false
tc.args = append([]string{tc.next, "name"}, tc.args...)
rule, err := newRule(tc.args...)
if err != nil {
failed = true
}
if !failed && !tc.expectedFail {
t.Logf("Test %d: PASS, passed as expected: (%s) %s", i, tc.next, tc.args)
continue
}
if failed && tc.expectedFail {
t.Logf("Test %d: PASS, failed as expected: (%s) %s: %s", i, tc.next, tc.args, err)
continue
}
t.Fatalf("Test %d: FAIL, expected fail=%t, but received fail=%t: (%s) %s, rule=%v", i, tc.expectedFail, failed, tc.next, tc.args, rule)
}
}