Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-28 08:44:17 -04:00
Code Issues Packages Projects Releases Wiki Activity

- compliance with metadata contract. If metadata value is empty, ignore rewrite - like if metadata does not exist. (#1953)

Browse Source
This commit is contained in:
Francois Tur
2018-07-08 17:38:46 -04:00
committed by Paul Greenberg
parent 7745462430
commit b3a92f1622
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
plugin/rewrite/edns0.go
View File

@@ -203,7 +203,10 @@ func (rule *edns0VariableRule) ruleData(ctx context.Context, state request.Reque
fetcher := metadata.ValueFunc(ctx, rule.variable[1:len(rule.variable)-1]) fetcher := metadata.ValueFunc(ctx, rule.variable[1:len(rule.variable)-1])
if fetcher != nil { if fetcher != nil {
return []byte(fetcher()), nil value := fetcher()
if len(value) > 0 {
return []byte(value), nil
}
} }
return nil, fmt.Errorf("unable to extract data for variable %s", rule.variable) return nil, fmt.Errorf("unable to extract data for variable %s", rule.variable)

4
plugin/rewrite/rewrite_test.go
View File

@@ -523,8 +523,8 @@ func TestRewriteEDNS0LocalVariable(t *testing.T) {
{ {
[]dns.EDNS0{}, []dns.EDNS0{},
[]string{"local", "set", "0xffee", "{test/empty}"}, []string{"local", "set", "0xffee", "{test/empty}"},
[]dns.EDNS0{&dns.EDNS0_LOCAL{Code: 0xffee, Data: []byte("")}}, nil,
true, false,
}, },
{ {
[]dns.EDNS0{}, []dns.EDNS0{},