Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-27 08:14:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

feat(plugin/file): fallthrough (#7327)

Browse Source 
* feat(plugin/file): fallthrough

implement and test fallthrough for the file plugin

Signed-off-by: vdbe <vdbewout@gmail.com>

* docs(plugin/file): fallthrough

Signed-off-by: vdbe <vdbewout@gmail.com>

* docs(plugin/file): regenerate man page

`make -f Makefile.doc man/coredns-file.7`

Signed-off-by: vdbe <vdbewout@gmail.com>

---------

Signed-off-by: vdbe <vdbewout@gmail.com>
This commit is contained in:
vdbe
2025-05-29 02:34:16 +02:00
committed by GitHub
parent bebb7bce43
commit b3acbe5046
6 changed files with 149 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
plugin/file/lookup_test.go
View File

@@ -6,6 +6,7 @@ import (
"testing"
"github.com/coredns/coredns/plugin/pkg/dnstest"
"github.com/coredns/coredns/plugin/pkg/fall"
"github.com/coredns/coredns/plugin/test"
"github.com/coredns/coredns/request"
@@ -216,6 +217,85 @@ func TestLookUpNoDataResult(t *testing.T) {
}
}
func TestLookupFallthrough(t *testing.T) {
zone, err := Parse(strings.NewReader(dbMiekNL), testzone, "stdin", 0)
if err != nil {
t.Fatalf("Expected no error when reading zone, got %q", err)
}
type FallWithTestCases struct {
Fall fall.F
Cases []test.Case
}
var fallsWithTestCases = []FallWithTestCases{
{
Fall: fall.Root,
Cases: []test.Case{
{
Qname: "doesnotexist.miek.nl.", Qtype: dns.TypeA,
Rcode: dns.RcodeServerFailure,
},
{
Qname: "x.miek.nl.", Qtype: dns.TypeA,
Rcode: dns.RcodeServerFailure,
},
},
},
{
Fall: fall.F{Zones: []string{"a.miek.nl."}},
Cases: []test.Case{
{
Qname: "a.miek.nl.", Qtype: dns.TypeA,
Rcode: dns.RcodeSuccess,
},
{
Qname: "doesnotexist.miek.nl.", Qtype: dns.TypeA,
Rcode: dns.RcodeNameError,
},
{
Qname: "passthrough.a.miek.nl.", Qtype: dns.TypeA,
Rcode: dns.RcodeServerFailure,
Answer: []dns.RR{},
},
},
},
{
Fall: fall.F{Zones: []string{"x.miek.nl."}},
Cases: []test.Case{
{
Qname: "x.miek.nl.", Qtype: dns.TypeA,
Rcode: dns.RcodeServerFailure,
},
{
Qname: "wildcard.x.miek.nl.", Qtype: dns.TypeA,
Rcode: dns.RcodeSuccess,
},
},
},
}
for _, fallWithTestCases := range fallsWithTestCases {
fm := File{Next: test.ErrorHandler(), Zones: Zones{Z: map[string]*Zone{testzone: zone}, Names: []string{testzone}}, Fall: fallWithTestCases.Fall}
ctx := context.TODO()
for _, tc := range fallWithTestCases.Cases {
m := tc.Msg()
rec := dnstest.NewRecorder(&test.ResponseWriter{})
_, err := fm.ServeDNS(ctx, rec, m)
if err != nil {
t.Errorf("Expected no error, got %v", err)
return
}
if rec.Msg.Rcode != tc.Rcode {
t.Errorf("rcode is %q, expected %q", dns.RcodeToString[rec.Msg.Rcode], dns.RcodeToString[tc.Rcode])
return
}
}
}
}
func BenchmarkFileLookup(b *testing.B) {
zone, err := Parse(strings.NewReader(dbMiekNL), testzone, "stdin", 0)
if err != nil {