Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-01 02:33:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

Golint middleware/proxy (#290)

Browse Source 
While looking into the proxy middleware it appears that there are
several golint messages:
```
ubuntu@ubuntu:~/coredns$ golint middleware/proxy/
middleware/proxy/lookup.go:66:1: exported method Proxy.Forward should have comment or be unexported
middleware/proxy/proxy.go:24:6: exported type Client should have comment or be unexported
middleware/proxy/proxy.go:107:1: exported function Clients should have comment or be unexported
middleware/proxy/reverseproxy.go:10:6: exported type ReverseProxy should have comment or be unexported
middleware/proxy/reverseproxy.go:16:1: exported method ReverseProxy.ServeDNS should have comment or be unexported
middleware/proxy/upstream.go:42:6: exported type Options should have comment or be unexported
```

This fix addressed the above golint messages.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This commit is contained in:
Yong Tang
2016-09-24 06:00:50 +08:00
committed by Miek Gieben
parent 0959b52e79
commit b9cf32f7a9
4 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
middleware/proxy/lookup.go
View File

@@ -63,6 +63,7 @@ func (p Proxy) Lookup(state request.Request, name string, tpe uint16) (*dns.Msg,
return p.lookup(state, req) return p.lookup(state, req)
} }
// Forward will forward the request to upstream
func (p Proxy) Forward(state request.Request) (*dns.Msg, error) { func (p Proxy) Forward(state request.Request) (*dns.Msg, error) {
return p.lookup(state, state.Req) return p.lookup(state, state.Req)
} }

2
middleware/proxy/proxy.go
View File

@@ -21,6 +21,7 @@ type Proxy struct {
Upstreams []Upstream Upstreams []Upstream
} }
// Client represents client information that the proxy uses.
type Client struct { type Client struct {
UDP *dns.Client UDP *dns.Client
TCP *dns.Client TCP *dns.Client
@@ -104,6 +105,7 @@ func (p Proxy) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (
return p.Next.ServeDNS(ctx, w, r) return p.Next.ServeDNS(ctx, w, r)
} }
// Clients returns the new client for proxy requests.
func Clients() Client { func Clients() Client {
udp := newClient("udp", defaultTimeout) udp := newClient("udp", defaultTimeout)
tcp := newClient("tcp", defaultTimeout) tcp := newClient("tcp", defaultTimeout)

2
middleware/proxy/reverseproxy.go
View File

@@ -7,12 +7,14 @@ import (
"github.com/miekg/dns" "github.com/miekg/dns"
) )
// ReverseProxy is a basic reverse proxy
type ReverseProxy struct { type ReverseProxy struct {
Host string Host string
Client Client Client Client
Options Options Options Options
} }
// ServeDNS implements the middleware.Handler interface.
func (p ReverseProxy) ServeDNS(w dns.ResponseWriter, r *dns.Msg, extra []dns.RR) error { func (p ReverseProxy) ServeDNS(w dns.ResponseWriter, r *dns.Msg, extra []dns.RR) error {
var ( var (
reply *dns.Msg reply *dns.Msg

1
middleware/proxy/upstream.go
View File

@@ -39,6 +39,7 @@ type staticUpstream struct {
options Options options Options
} }
// Options ...
type Options struct { type Options struct {
Ecs []*net.IPNet // EDNS0 CLIENT SUBNET address (v4/v6) to add in CIDR notaton. Ecs []*net.IPNet // EDNS0 CLIENT SUBNET address (v4/v6) to add in CIDR notaton.
} }