Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-22 11:52:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

all: gometalinter (#843)

Browse Source 
* kubernetes/reverse: remove deadcode
* deadcode in errors and kubernetes removed
* unnecessary conversion
* constants
* proxy: time.Since()
* simplications
* static check
* Disable test/external_test
This commit is contained in:
Miek Gieben
2017-08-06 05:54:24 -07:00
committed by GitHub
parent 964f04f443
commit bcb2eb1ecc
25 changed files with 105 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
middleware/file/lookup.go
View File

@@ -231,7 +231,7 @@ func (z *Zone) Lookup(state request.Request, qname string) ([]dns.RR, []dns.RR,
ret := z.soa(do)
if do {
deny, found := z.Tree.Prev(qname)
deny, _ := z.Tree.Prev(qname) // TODO(miek): *found* was not used here.
nsec := z.typeFromElem(deny, dns.TypeNSEC, do)
ret = append(ret, nsec...)

6
middleware/file/notify.go
View File

@@ -61,12 +61,12 @@ func notify(zone string, to []string) error {
return nil
}
func notifyAddr(c *dns.Client, m *dns.Msg, s string) (err error) {
ret := new(dns.Msg)
func notifyAddr(c *dns.Client, m *dns.Msg, s string) error {
var err error
code := dns.RcodeServerFailure
for i := 0; i < 3; i++ {
ret, _, err = c.Exchange(m, s)
ret, _, err := c.Exchange(m, s)
if err != nil {
continue
}