all: gometalinter (#843)

* kubernetes/reverse: remove deadcode
* deadcode in errors and kubernetes removed
* unnecessary conversion
* constants
* proxy: time.Since()
* simplications
* static check
* Disable test/external_test

middleware/trace/setup.go

@@ -97,7 +97,7 @@ func traceParse(c *caddy.Controller) (*trace, error) {
 func normalizeEndpoint(epType, ep string) (string, error) {
 	switch epType {
 	case "zipkin":
-		if strings.Index(ep, "http") == -1 {
+		if !strings.Contains(ep, "http") {
 			ep = "http://" + ep + "/api/v1/spans"
 		}
 		return ep, nil