From bebb7bce430b9a63eaf81b258d002c5128d28f4f Mon Sep 17 00:00:00 2001 From: Ville Vesilehto Date: Thu, 29 May 2025 03:33:07 +0300 Subject: [PATCH] lint: enable canonicalheader linter (#7330) Enable canonicalheader linter to enforce proper HTTP header casing. This ensures headers use Go's canonical format (e.g., "Content-Type" instead of "content-type") for consistency. Fixes header casing in DoH implementation. Signed-off-by: Ville Vesilehto --- .golangci.yml | 1 + plugin/pkg/doh/doh.go | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 19d1ab4f3..621db83ba 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -2,6 +2,7 @@ version: "2" linters: default: none enable: + - canonicalheader - copyloopvar - govet - ineffassign diff --git a/plugin/pkg/doh/doh.go b/plugin/pkg/doh/doh.go index 35764eeae..d125dd681 100644 --- a/plugin/pkg/doh/doh.go +++ b/plugin/pkg/doh/doh.go @@ -45,8 +45,8 @@ func NewRequest(method, url string, m *dns.Msg) (*http.Request, error) { return req, err } - req.Header.Set("content-type", MimeType) - req.Header.Set("accept", MimeType) + req.Header.Set("Content-Type", MimeType) + req.Header.Set("Accept", MimeType) return req, nil case http.MethodPost: @@ -59,8 +59,8 @@ func NewRequest(method, url string, m *dns.Msg) (*http.Request, error) { return req, err } - req.Header.Set("content-type", MimeType) - req.Header.Set("accept", MimeType) + req.Header.Set("Content-Type", MimeType) + req.Header.Set("Accept", MimeType) return req, nil default: