From c2acad28667b435f07c1b86bdbcba6b8dbdb9cd7 Mon Sep 17 00:00:00 2001 From: ump45nose <52391318+ump45nose@users.noreply.github.com> Date: Wed, 21 Oct 2026 08:17:06 +0800 Subject: [PATCH] plugin/k8s_external: correct the SOA example in the docs (#8666) The README and man page introduce the apex with "By default the apex of the zone will look like the following", but the SOA fields shown do not match what soa() actually emits. plugin/k8s_external/apex.go sets Refresh 7200, Retry 1800, Expire 86400 and Minttl e.ttl (default 5 seconds), while the example listed 14400/3600/604800 and annotated the minimum value of 5 as "4 hours". Align the example with the emitted values and fix the minimum's unit. Signed-off-by: Vincent <1729065730@qq.com> --- man/coredns-k8s_external.7 | 8 ++++---- plugin/k8s_external/README.md | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/man/coredns-k8s_external.7 b/man/coredns-k8s_external.7 index 657620c73..aa75c963c 100644 --- a/man/coredns-k8s_external.7 +++ b/man/coredns-k8s_external.7 @@ -23,10 +23,10 @@ By default the apex of the zone will look like the following (assuming the zone .nf example.org. 5 IN SOA ns1.dns.example.org. hostmaster.example.org. ( 12345 ; serial - 14400 ; refresh (4 hours) - 3600 ; retry (1 hour) - 604800 ; expire (1 week) - 5 ; minimum (4 hours) + 7200 ; refresh (2 hours) + 1800 ; retry (30 minutes) + 86400 ; expire (1 day) + 5 ; minimum (5 seconds) ) example.org 5 IN NS ns1.dns.example.org. diff --git a/plugin/k8s_external/README.md b/plugin/k8s_external/README.md index 893a13158..f8621a4a0 100644 --- a/plugin/k8s_external/README.md +++ b/plugin/k8s_external/README.md @@ -17,10 +17,10 @@ By default the apex of the zone will look like the following (assuming the zone ~~~ dns example.org. 5 IN SOA ns1.dns.example.org. hostmaster.example.org. ( 12345 ; serial - 14400 ; refresh (4 hours) - 3600 ; retry (1 hour) - 604800 ; expire (1 week) - 5 ; minimum (4 hours) + 7200 ; refresh (2 hours) + 1800 ; retry (30 minutes) + 86400 ; expire (1 day) + 5 ; minimum (5 seconds) ) example.org 5 IN NS ns1.dns.example.org.