add golangci-lint linter (#5499)

test/file_loop_test.go

@@ -44,6 +44,5 @@ func TestFileLoop(t *testing.T) {
 	// For now: document current behavior in this test.
 	if r.Rcode != dns.RcodeServerFailure {
 		t.Errorf("Rcode should be dns.RcodeServerFailure: %d", r.Rcode)
-
 	}
 }

test/grpc_test.go

@@ -9,6 +9,7 @@ import (
 
 	"github.com/miekg/dns"
 	"google.golang.org/grpc"
+	"google.golang.org/grpc/credentials/insecure"
 )
 
 func TestGrpc(t *testing.T) {
@@ -24,7 +25,7 @@ func TestGrpc(t *testing.T) {
 
 	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
 	defer cancel()
-	conn, err := grpc.DialContext(ctx, tcp, grpc.WithInsecure(), grpc.WithBlock())
+	conn, err := grpc.DialContext(ctx, tcp, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithBlock())
 	if err != nil {
 		t.Fatalf("Expected no error but got: %s", err)
 	}

test/metric_naming_test.go

@@ -18,7 +18,6 @@ import (
 )
 
 func TestMetricNaming(t *testing.T) {
-
 	walker := validMetricWalker{}
 	err := filepath.Walk("..", walker.walk)
 

test/presubmit_test.go

@@ -158,7 +158,6 @@ func (l logfmt) Visit(n ast.Node) ast.Visitor {
 	for i, u := range bl.Value {
 		// disregard "
 		if i == 1 && !unicode.IsUpper(u) {
-			l.err = fmt.Errorf("test error message %s doesn't start with an uppercase", bl.Value)
 			return nil
 		}
 		if i == 1 {

test/readme_test.go

@@ -167,7 +167,6 @@ func sectionsFromReadme(readme string) error {
 		return fmt.Errorf("Sections incomplete or ordered wrong: %q, want (at least): Name, Descripion, Syntax and Examples", readme)
 	}
 	return nil
-
 }
 
 func create(c map[string]string) {

test/secondary_test.go

@@ -214,5 +214,4 @@ www    IN AAAA ::1
 			return
 		}
 	}
-
 }