Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-26 15:54:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

plugin/health: remove ability to poll other plugins (#2547)

Browse Source 
* plugin/health: remove ability to poll other plugins

This mechanism defeats the purpose any plugin (mostly) caching can still
be alive, we can probably forward queries still. Don't poll plugins,
just tell the world we're up and running.

It was only actually used in kubernetes; and there specifically would
mean any network hiccup would NACK the entire server health.

Fixes: #2534

Signed-off-by: Miek Gieben <miek@miek.nl>

* update docs based on feedback

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben
2019-03-07 22:13:47 +00:00
committed by GitHub
parent db0b16b615
commit c778b3a67c
10 changed files with 18 additions and 173 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
plugin.md
View File

@@ -59,10 +59,7 @@ When exporting metrics the *Namespace* should be `plugin.Namespace` (="coredns")
*Subsystem* should be the name of the plugin. The README.md for the plugin should then also contain
a *Metrics* section detailing the metrics.
If the plugin supports dynamic health reporting it should also have *Health* section detailing on
some of its inner workings.
If the plugins supports signalling readiness it should have a *Ready* section detailing how it
If the plugin supports signalling readiness it should have a *Ready* section detailing how it
works.
## Documentation