Remove the word middleware (#1067)

* Rename middleware to plugin

first pass; mostly used 'sed', few spots where I manually changed
text.

This still builds a coredns binary.

* fmt error

* Rename AddMiddleware to AddPlugin

* Readd AddMiddleware to remain backwards compat

plugin/erratic/erratic_test.go

@@ -0,0 +1,79 @@
+package erratic
+
+import (
+	"testing"
+
+	"github.com/coredns/coredns/plugin/pkg/dnsrecorder"
+	"github.com/coredns/coredns/plugin/test"
+
+	"github.com/miekg/dns"
+	"golang.org/x/net/context"
+)
+
+func TestErraticDrop(t *testing.T) {
+	e := &Erratic{drop: 2} // 50% drops
+
+	tests := []struct {
+		expectedCode int
+		expectedErr  error
+		drop         bool
+	}{
+		{expectedCode: dns.RcodeSuccess, expectedErr: nil, drop: true},
+		{expectedCode: dns.RcodeSuccess, expectedErr: nil, drop: false},
+	}
+
+	ctx := context.TODO()
+
+	for i, tc := range tests {
+		req := new(dns.Msg)
+		req.SetQuestion("example.org.", dns.TypeA)
+
+		rec := dnsrecorder.New(&test.ResponseWriter{})
+		code, err := e.ServeDNS(ctx, rec, req)
+
+		if err != tc.expectedErr {
+			t.Errorf("Test %d: Expected error %q, but got %q", i, tc.expectedErr, err)
+		}
+		if code != int(tc.expectedCode) {
+			t.Errorf("Test %d: Expected status code %d, but got %d", i, tc.expectedCode, code)
+		}
+
+		if tc.drop && rec.Msg != nil {
+			t.Errorf("Test %d: Expected dropped message, but got %q", i, rec.Msg.Question[0].Name)
+		}
+	}
+}
+
+func TestErraticTruncate(t *testing.T) {
+	e := &Erratic{truncate: 2} // 50% drops
+
+	tests := []struct {
+		expectedCode int
+		expectedErr  error
+		truncate     bool
+	}{
+		{expectedCode: dns.RcodeSuccess, expectedErr: nil, truncate: true},
+		{expectedCode: dns.RcodeSuccess, expectedErr: nil, truncate: false},
+	}
+
+	ctx := context.TODO()
+
+	for i, tc := range tests {
+		req := new(dns.Msg)
+		req.SetQuestion("example.org.", dns.TypeA)
+
+		rec := dnsrecorder.New(&test.ResponseWriter{})
+		code, err := e.ServeDNS(ctx, rec, req)
+
+		if err != tc.expectedErr {
+			t.Errorf("Test %d: Expected error %q, but got %q", i, tc.expectedErr, err)
+		}
+		if code != int(tc.expectedCode) {
+			t.Errorf("Test %d: Expected status code %d, but got %d", i, tc.expectedCode, code)
+		}
+
+		if tc.truncate && !rec.Msg.Truncated {
+			t.Errorf("Test %d: Expected truncated message, but got %q", i, rec.Msg.Question[0].Name)
+		}
+	}
+}