Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-02 02:03:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

core: replace GetMiddleware (#885)

Browse Source 
* core: replace GetMiddleware

See the discussion in #881. GetMiddleware would add a `nil` middleware
to the callstack thereby breaking functionality.

This PR drops it in favor of RegisterHandler which is a completely
standalone registry for middleware that want to let it self know to
other middleware.

Currenly *autopath* uses this to call *kubernetes*'s AutoPath method
for dynamic autopathing.

* Drop GetMiddleware

* Register metrics

* drop the panic
This commit is contained in:
Miek Gieben
2017-08-10 21:31:36 +01:00
committed by GitHub
parent 10681c6bf0
commit ea77f2a2ca
7 changed files with 53 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
middleware/auto/setup.go
View File

@@ -32,7 +32,9 @@ func setup(c *caddy.Controller) error {
}
// If we have enabled prometheus we should add newly discovered zones to it.
met := dnsserver.GetMiddleware(c, "prometheus")
// This does not have to happen in a on.Startup because monitoring is one of the first
// to be initialized.
met := dnsserver.GetConfig(c).GetHandler("prometheus")
if met != nil {
a.metrics = met.(*metrics.Metrics)
}