mirror of
https://github.com/coredns/coredns.git
synced 2026-10-17 15:55:47 -04:00
plugin/azure: add refresh directive (#8614)
Brings azure to parity with route53, which already exposes a refresh directive to control how often zones are re-synced. azure currently hardcodes this to 1 minute (Run calls h.run(ctx, time.Minute)) with no way to change it, even though the internal run() method already takes an arbitrary interval parameter - the plumbing exists, it just wasn't exposed as a Corefile option. Adds a refresh field to the Azure struct, threads it through New(), and has Run() use h.refresh instead of the hardcoded value. Parses the refresh directive in parse() mirroring route53's exact validation (accepts a plain number as seconds or a duration string, must be greater than 0). Extends TestSetup with refresh coverage (valid duration, valid plain number, missing arg, non-numeric, zero, negative). Verified it fails without the setup.go change (unknown property error) and passes with it. Signed-off-by: stackedbyaradhya <aradhyaj736@gmail.com>
This commit is contained in:
@@ -35,6 +35,24 @@ func TestSetup(t *testing.T) {
|
||||
}`, false, nil},
|
||||
{`azure resource_set:zone {
|
||||
foo
|
||||
}`, true, nil},
|
||||
{`azure resource_set:zone {
|
||||
refresh 3m
|
||||
}`, false, nil},
|
||||
{`azure resource_set:zone {
|
||||
refresh 30
|
||||
}`, false, nil},
|
||||
{`azure resource_set:zone {
|
||||
refresh
|
||||
}`, true, nil},
|
||||
{`azure resource_set:zone {
|
||||
refresh abc
|
||||
}`, true, nil},
|
||||
{`azure resource_set:zone {
|
||||
refresh 0
|
||||
}`, true, nil},
|
||||
{`azure resource_set:zone {
|
||||
refresh -5m
|
||||
}`, true, nil},
|
||||
{`azure resource_set:zone {
|
||||
tenant tenant_id
|
||||
@@ -75,7 +93,7 @@ func TestSetup(t *testing.T) {
|
||||
|
||||
for i, test := range tests {
|
||||
c := caddy.NewTestController("dns", test.body)
|
||||
_, _, accessMap, _, err := parse(c)
|
||||
_, _, accessMap, _, _, err := parse(c)
|
||||
if (err == nil) == test.expectedError {
|
||||
t.Fatalf("Unexpected errors: %v in test: %d\n\t%s", err, i, test.body)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user