Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2026-04-07 20:45:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(kubernetes): record cluster_ip services in dns_programming_duration metric (#7951)

Browse Source 
Signed-off-by: Azeez Syed <syedazeez337@gmail.com>
This commit is contained in:
Syed Azeez
2026-03-24 17:59:28 +05:30
committed by GitHub
parent 734426798f
commit f582a01dc9
3 changed files with 125 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
plugin/kubernetes/object/metrics.go
View File

@@ -62,22 +62,23 @@ func (l *EndpointLatencyRecorder) init(o meta.Object) {
}
func (l *EndpointLatencyRecorder) record() {
// isHeadless indicates whether the endpoints object belongs to a headless
// service (i.e. clusterIp = None). Note that this can be a false negatives if the service
// informer is lagging, i.e. we may not see a recently created service. Given that the services
// don't change very often (comparing to much more frequent endpoints changes), cases when this method
// will return wrong answer should be relatively rare. Because of that we intentionally accept this
// flaw to keep the solution simple.
isHeadless := len(l.Services) == 1 && l.Services[0].Headless()
if !isHeadless || l.TT.IsZero() {
// Note: len(l.Services) != 1 can be a false negative if the service informer is lagging,
// i.e. we may not see a recently created service. Given that services don't change very
// often (compared to much more frequent endpoint changes), cases when this method skips
// recording should be relatively rare. We intentionally accept this flaw to keep the
// solution simple.
if l.TT.IsZero() || len(l.Services) != 1 {
return
}
// If we're here it means that the Endpoints object is for a headless service and that
// the Endpoints object was created by the endpoints-controller (because the
// LastChangeTriggerTime annotation is set). It means that the corresponding service is a
// "headless service with selector".
DNSProgrammingLatency.WithLabelValues("headless_with_selector").
// If we're here it means that the Endpoints object was created by the endpoints-controller
// (because the LastChangeTriggerTime annotation is set) and the backing Service is known.
// For headless services this means the service has a selector ("headless_with_selector").
// For non-headless services the service kind is "cluster_ip".
serviceKind := "cluster_ip"
if l.Services[0].Headless() {
serviceKind = "headless_with_selector"
}
DNSProgrammingLatency.WithLabelValues(serviceKind).
Observe(DurationSinceFunc(l.TT).Seconds())
}