return an error for multiple use of some plugins (#1559)

* plugins: Return error for multiple use of some

Return plugin.ErrOnce when a plugin that doesn't support it, is called
mutliple times.

This now adds it for: cache, dnssec, errors, forward, hosts, nsid.
And changes it slightly in kubernetes, pprof, reload, root.

* more tests
This commit is contained in:
Miek Gieben
2018-02-28 18:16:05 -08:00
committed by GitHub
parent 5faa9e7bc1
commit f697b33283
27 changed files with 150 additions and 95 deletions

View File

@@ -12,21 +12,14 @@ func TestErrorsParse(t *testing.T) {
shouldErr bool
expectedErrorHandler errorHandler
}{
{`errors`, false, errorHandler{
LogFile: "stdout",
}},
{`errors stdout`, false, errorHandler{
LogFile: "stdout",
}},
{`errors errors.txt`, true, errorHandler{
LogFile: "",
}},
{`errors visible`, true, errorHandler{
LogFile: "",
}},
{`errors { log visible }`, true, errorHandler{
LogFile: "stdout",
}},
{`errors`, false, errorHandler{LogFile: "stdout"}},
{`errors stdout`, false, errorHandler{LogFile: "stdout"}},
{`errors errors.txt`, true, errorHandler{LogFile: ""}},
{`errors visible`, true, errorHandler{LogFile: ""}},
{`errors { log visible }`, true, errorHandler{LogFile: "stdout"}},
{`errors
errors `, true, errorHandler{LogFile: "stdout"}},
{`errors a b`, true, errorHandler{LogFile: ""}},
}
for i, test := range tests {
c := caddy.NewTestController("dns", test.inputErrorsRules)