Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-02 02:03:13 -05:00
Code Issues Packages Projects Releases Wiki Activity

return an error for multiple use of some plugins (#1559)

Browse Source 
* plugins: Return error for multiple use of some

Return plugin.ErrOnce when a plugin that doesn't support it, is called
mutliple times.

This now adds it for: cache, dnssec, errors, forward, hosts, nsid.
And changes it slightly in kubernetes, pprof, reload, root.

* more tests
This commit is contained in:
Miek Gieben
2018-02-28 18:16:05 -08:00
committed by GitHub
parent 5faa9e7bc1
commit f697b33283
27 changed files with 150 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
plugin/nsid/setup.go
View File

@@ -36,13 +36,16 @@ func nsidParse(c *caddy.Controller) (string, error) {
if err != nil {
nsid = "localhost"
}
i := 0
for c.Next() {
args := c.RemainingArgs()
if len(args) == 0 {
return nsid, nil
if i > 0 {
return nsid, plugin.ErrOnce
}
i++
args := c.RemainingArgs()
if len(args) > 0 {
nsid = strings.Join(args, " ")
}
nsid = strings.Join(args, " ")
return nsid, nil
}
return nsid, nil
}