Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-10-27 16:24:19 -04:00
Code Issues Packages Projects Releases Wiki Activity

Ensure Re-register of metrics variables after a reload (#2080)

Browse Source 
* - ensure plugins that use prometheus.MustRegister, re-register after reload
- removing once.Do on the startup function was simplest way to do it.

* - fix underscored names (advice of bot)

* - tune existing UT for reload, and add a test verifying failing reload does not prevent correct registering for metrics

* - ensure different ports for tests that can run in same time ..
This commit is contained in:
Francois Tur
2018-09-19 05:11:24 -04:00
committed by Yong Tang
parent cb932ca231
commit f9bdd382dd
13 changed files with 143 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugin/dnssec/handler.go
View File

@@ -2,7 +2,6 @@ package dnssec
import (
"context"
"sync"
"github.com/coredns/coredns/plugin"
"github.com/coredns/coredns/plugin/metrics"
@@ -81,5 +80,3 @@ var (
// Name implements the Handler interface.
func (d Dnssec) Name() string { return "dnssec" }
var once sync.Once