mirror of
https://github.com/coredns/coredns.git
synced 2025-10-28 00:34:24 -04:00
pkg/typify: empty messages are OtherError (#1531)
Messages with nothing in them are considered OtherError, they can not serve any purpose for normal clients (i.e. dyn update or notifies might have a use for them). Also update a test in the cache plugin, so that we explicitaly test for this case.
This commit is contained in:
2
plugin/cache/cache.go
vendored
2
plugin/cache/cache.go
vendored
@@ -171,7 +171,7 @@ func (w *ResponseWriter) set(m *dns.Msg, key int, mt response.Type, duration tim
|
||||
case response.OtherError:
|
||||
// don't cache these
|
||||
default:
|
||||
log.Printf("[WARNING] Caching called with unknown classification: %d", mt)
|
||||
log.Printf("[WARNING] Caching called with unknown typification: %d", mt)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user