Mirrors/coredns
1
0
Fork 0
mirror of https://github.com/coredns/coredns.git synced 2025-11-01 02:33:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

Some go vet cleanup (#869)

Browse Source 
Some `go vet` cleanup

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This commit is contained in:
Yong Tang
2017-08-09 11:00:03 -07:00
committed by Miek Gieben
parent 654d127a24
commit fefc4374d7
3 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
middleware/autopath/autopath_test.go
View File

@@ -132,8 +132,6 @@ func nextHandler(mm map[string]int) test.Handler {
default: default:
panic("nextHandler: unhandled rcode") panic("nextHandler: unhandled rcode")
} }
return dns.RcodeServerFailure, nil
}) })
} }
@@ -159,7 +157,7 @@ func TestInSearchPath(t *testing.T) {
for i, tc := range tests { for i, tc := range tests {
got := a.FirstInSearchPath(tc.qname) got := a.FirstInSearchPath(tc.qname)
if got != tc.b { if got != tc.b {
t.Errorf("Test %d, got %d, expected %d", i, got, tc.b) t.Errorf("Test %d, got %v, expected %v", i, got, tc.b)
} }
} }
} }

2
middleware/autopath/setup_test.go
View File

@@ -14,7 +14,7 @@ import (
func TestSetupAutoPath(t *testing.T) { func TestSetupAutoPath(t *testing.T) {
resolv, rm, err := test.TempFile(os.TempDir(), resolvConf) resolv, rm, err := test.TempFile(os.TempDir(), resolvConf)
if err != nil { if err != nil {
t.Fatalf("Could not create resolv.conf test file: %s", resolvConf, err) t.Fatalf("Could not create resolv.conf test file %s: %s", resolvConf, err)
} }
defer rm() defer rm()

2
middleware/pkg/dnsutil/zone_test.go
View File

@@ -24,7 +24,7 @@ func TestTrimZone(t *testing.T) {
for i, tc := range tests { for i, tc := range tests {
got, err := TrimZone(dns.Fqdn(tc.qname), dns.Fqdn(tc.zone)) got, err := TrimZone(dns.Fqdn(tc.qname), dns.Fqdn(tc.zone))
if tc.err != nil && err == nil { if tc.err != nil && err == nil {
t.Errorf("Test %d, expected error got nil") t.Errorf("Test %d, expected error got nil", i)
continue continue
} }
if tc.err == nil && err != nil { if tc.err == nil && err != nil {