Commit Graph

27 Commits

Author SHA1 Message Date
Yong Tang
619a0aedc0 Switch from actions/setup-go@v2-beta to actions/setup-go@v2 to fix the GitHub Actions set-env failure (#4302)
This PR switches from actions/setup-go@v2-beta to actions/setup-go@v2 to fix the
GitHub Actions `set-env` failure. Without this PR the following error shown up
(see https://github.com/coredns/coredns/runs/1423802307):
```
Error: Unable to process command '::set-env name=GOROOT::/opt/hostedtoolcache/go/1.15.5/x64' successfully.
7
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
```

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2020-11-19 15:40:41 -05:00
Yong Tang
2845eaa916 Fix missing * in Go Fmt GitHub Actions (#4277)
Looks like one `*` is missing in Go Fmt GitHub Actions
and that causes the Actions not being triggered.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2020-11-11 07:43:46 +01:00
coredns-auto-trailing-whitespaces[bot]
dd078a982c auto remove trailing whitespaces 2020-11-07 18:57:52 +00:00
Yong Tang
37e3a81f25 Remove redundant '' as Linux does not need it.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2020-11-07 10:57:02 -08:00
Yong Tang
263423edad Setup GitHub Actions for auto remove trailing whitespaces (#4269)
* Setup GitHub Actions for auto remove trailing whitespaces

This PR setup GitHub Actions for auto remove trailing whitespaces,
if any non-go files are touched (.git directory are ignored)

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Remove TestTrailingWhitespace in presubmit tests

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* paths and paths-ignore are mutually exlcusive so only keep paths-ignore

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Remove redundent bufio import

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2020-11-07 10:53:20 -08:00
Yong Tang
67f2048bb0 Add GitHub Actions to gofmt -s -w all *.go files (#4268)
* Add GitHub Actions to  `gofmt -s -w` all `*.go` files

This PR adds GitHub Actions to  `gofmt -s -w` all `*.go` files,
if any `*.go` files are touched on each commit.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Change go-mod-fmt to go-fmt

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2020-11-06 17:44:11 +01:00
Miek Gieben
cd5ee7d1f0 Remove travis and move to github workflow (#4267)
Add github testing workflow, simplify the Makefile because that was
complex because of Travis. Remove the fuzzing, needs to be re-added when
that works properly with go modules (it has been disabled for quite some
time). Multiple builds and files have been added so these tests can all
run in parallel. Our testing now tests a couple of minutes, the codeql
is by far the more expensive.

Move metric's naming test to test/presubmit_test.go

Add longer sleep in the TestAutoAXFR.

Bye bye travis!

Closes: #4266

Signed-off-by: Miek Gieben <miek@miek.nl>
2020-11-06 14:14:26 +01:00
Miek Gieben
57e6c56bfc Create codeql-analysis.yml (#4264)
Setup CodeQL to check are code - seems we're in the beta. (is this still beta?)
2020-11-05 16:06:32 +01:00
Miek Gieben
d6660f369e A question template (#4243)
We get many questions (which is fine), but those are neither a bug, nor
an enhancement. Just add generic question as an option.

Signed-off-by: Miek Gieben <miek@miek.nl>
2020-10-27 14:55:34 +01:00
Olivier Lemasle
d371738149 Add DCO requirement in Contributing guidelines (#4008)
Signed-off-by: Olivier Lemasle <o.lemasle@gmail.com>
2020-07-14 18:38:57 +02:00
Ben Kochie
d4cac0c43a Move doc test to workflow (#3800)
Replace doc CI test with automatic workflow.

Signed-off-by: Ben Kochie <superq@gmail.com>
2020-03-31 16:18:10 +02:00
Miek Gieben
04292f1375 presubmit: add whitespace test in go (#3629)
Automatically submitted.
2020-01-28 11:13:11 +00:00
Michael Grosser
dd58f046de Use latest Github checkout action (#3627)
Signed-off-by: Michael Grosser <development@stp-ip.net>
2020-01-27 08:50:29 -08:00
Yong Tang
6cf1c086ac Update auto go mod tidy workflow to remove user association (#3517)
This PR updates go.tidy.yml, and use pseudo name
`coredns-auto-go-mod-tidy[bot]`, so that the commit
is not associated with real user. Otherwise
the commit history could be confusing.

This is similar to what `dependabot[bot]` is doing
for commits generated by bots.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-12-07 23:45:27 +00:00
Yong Tang
0a6100048d Setup GitHub Workflow for auto go tidy (#3512)
Setup GitHub Workflow for auto `go tidy`, when
- 'go.mod'
- 'go.sum'
- '.github/workflows/go.tidy.yml'
has been touched.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-12-07 15:49:38 +00:00
Yong Tang
bb077c0e49 Update GitHub template for CODE-OF-CONDUCT.md => .github/CODE_OF_CONDUCT.md (#3514)
This PR updates GitHub template for `CODE-OF-CONDUCT.md => `.github/CODE_OF_CONDUCT.md`,
to take advantage of GitHub feature in:

https://help.github.com/en/github/building-a-strong-community/adding-a-code-of-conduct-to-your-project

This PR also moves `SECURITY.md` to `.github/SECURITY.md` and alias it for consistency.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2019-12-07 15:45:27 +00:00
Miek Gieben
6cac0de83a Update github templates (#3510)
An ISSUE_TEMPLATE directory was added, meaning the ISSUE_TEMPLATE.md is
now obsolete. Remove stale.yml because not used. Symlink CONTRIBUTING.md
the other way around to get GitHub recognize it.

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-12-07 04:04:14 -08:00
Zou Nengren
2503df9056 introduce issue and pull request templates (#3493)
* introduce issue and pull request templates

Signed-off-by: zouyee <zounengren@cmss.chinamobile.com>

* introduce issue and pull request templates

Signed-off-by: zouyee <zounengren@cmss.chinamobile.com>
2019-11-30 11:33:49 +01:00
Miek Gieben
ab4262d7eb Add CONTRIBUTING symlink (#2540)
symlink from within .github

This should be enough to show it in pull request; unless github has
something against symlinks.

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-02-08 17:07:50 +00:00
Chris O'Haver
8b3e4e0687 Ask if the PR introduces backward incompatibility (#2538) 2019-02-08 16:30:17 +00:00
Chris O'Haver
35c5474660 Create ISSUE_TEMPLATE.md (#2297) 2018-11-13 15:32:40 +00:00
Miek Gieben
58d6991363 Update the pr template (#1862)
Add "Why is this needed".

I can get a description of what the PR does from the code changes,
answering the why question is more important.
2018-06-07 13:48:23 -07:00
Miek Gieben
f621870d9c Dont autoclose bugs (#1250) 2017-11-22 15:18:13 +00:00
Miek Gieben
4cedc8f902 extend stale-bot's deadline (#1224)
Add a note in about using the 'pinned' label for prevent stalebot from
closing your issue.
2017-11-13 10:16:38 +00:00
Miek Gieben
4fc381a491 Stalebot (#1165)
* stalebot: use wontfix-stalebot

I've added two new labels: wontfix-stalebot and pinned.

Wontfix-stalebot will be used by stalebot and pinned can be used to keep
issues open.

* later as well
2017-10-23 19:46:18 +01:00
Miek Gieben
25b2c538c1 probot: add 2 integrations (#1129)
close stale issues and stop the merging of PR with WIP in the name.
2017-10-02 20:12:55 +01:00
Yong Tang
6f874f0bd1 Add Pull Request templates (#1086)
This fix adds a Pull Request templates to be used.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2017-09-15 23:53:18 +01:00