Ville Vesilehto
0dd76bd9b1
fix(transfer): goroutine leak on axfr err ( #7516 )
2025-09-05 13:13:11 -07:00
Zhizhen He
2fe5890d8b
Fix typos ( #6235 )
...
* Fix typos and add todo to fix spelling of dnsutil.MaximumDefaulTTL
Signed-off-by: Zhizhen He <hezhizhen.yi@gmail.com >
2023-08-10 11:06:48 -04:00
Ondřej Benkovský
c2dbb7141a
add golangci-lint linter ( #5499 )
2022-07-10 11:06:33 -07:00
Chris O'Haver
68e141eff2
plugin/tsig: new plugin TSIG ( #4957 )
...
* expose tsig secrets via dnsserver.Config
* add tsig plugin
Signed-off-by: Chris O'Haver <cohaver@infoblox.com >
2022-06-27 15:48:34 -04:00
Miek Gieben
56bc7f399a
plugin/transfer: only allow outgoing axfr over tcp ( #4452 )
...
* plugin/transfer: only allow outgoing axfr over tcp
Return refused when the query comes in over udp.
No need to add a new test case as the current crop needed to be changed
to use TCP.
Fixes : #4450
Signed-off-by: Miek Gieben <miek@miek.nl >
* transfer tests: this needs tcp as well
Signed-off-by: Miek Gieben <miek@miek.nl >
2021-02-05 10:51:29 +01:00
Miek Gieben
d31b118978
plugin/transfer: fix go-routine leak ( #4380 )
...
PR #4161 is stalled. Tried to cherry pick the code from there, but that
led to conflicts, manually copying over while taking into account the
comments on that PR. Use that code and extend the error checking, don't
modify existing tests and make the badwriter test simpler.
Closes : #4161
Signed-off-by: Miek Gieben <miek@miek.nl >
add tests
Signed-off-by: Miek Gieben <miek@miek.nl >
2021-01-13 09:16:01 +01:00
Miek Gieben
623d1e01e2
plugin/transfer: remove duplicate code ( #4200 )
...
Was running coredns-master on my servers and kept seeing:
~~~
okt 14 10:38:06.473281 deb coredns[30303]: [INFO] plugin/transfer: Outgoing incremental transfer for up to date zone "miek.nl." to 37.97.149.87 for 1602370680 SOA serial
okt 14 10:40:06.498512 deb coredns[30303]: [INFO] plugin/transfer: Outgoing incremental transfer for up to date zone "miek.nl." to 37.97.149.87 for 1602370680 SOA serial
okt 14 10:42:06.553747 deb coredns[30303]: [INFO] plugin/transfer: Outgoing incremental transfer for up to date zone "miek.nl." to 37.97.149.87 for 1602370680 SOA serial
~~~
and I'm like shouldn't that be noop transfer? And sure enough, a
duplicated code block in the transfer code that logs this, so the `noop`
line is never reached.
Signed-off-by: Miek Gieben <miek@miek.nl >
2020-10-14 09:09:39 -04:00
Yong Tang
9798dd067f
Cherry-pick: Implement notifies for transfer plugin ( #3972 ) ( #4142 )
...
* Implement notifies for transfer plugin (#3972 )
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* really fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* Add transfer tests
copied and modified from #3452
Signed-off-by: Miek Gieben <miek@miek.nl >
* Test correct selection of plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* add upstream back in
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* properly merge
Signed-off-by: Miek Gieben <miek@miek.nl >
* Remove plugin/kubernetes/setup_transfer_test.go
Signed-off-by: Yong Tang <yong.tang.github@outlook.com >
Co-authored-by: Miek Gieben <miek@miek.nl >
2020-09-24 20:30:39 +02:00
Miek Gieben
24e668ecf0
goreport card fixes ( #4139 )
...
This fixes some inefassign as report by Go report card:
https://goreportcard.com/report/github.com/coredns/coredns
Signed-off-by: Miek Gieben <miek@miek.nl >
2020-09-22 09:22:00 +02:00
Yong Tang
614d08cba2
Revert "Implement notifies for transfer plugin ( #3972 )" ( #3995 )
...
This reverts commit 68f1dd5ddfyong.tang.github@outlook.com >
2020-07-08 09:00:26 -07:00
Miek Gieben
68f1dd5ddf
Implement notifies for transfer plugin ( #3972 )
...
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* really fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* Add transfer tests
copied and modified from #3452
Signed-off-by: Miek Gieben <miek@miek.nl >
* Test correct selection of plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* add upstream back in
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* properly merge
Signed-off-by: Miek Gieben <miek@miek.nl >
2020-07-07 12:38:07 -07:00
Guangming Wang
113783ed91
Call wg.Add in main goroutine to avoid race conditons. ( #3433 )
...
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io >
2019-11-07 15:29:50 +00:00
Chris O'Haver
a7ab592e78
plugin/transfer: Zone transfer plugin ( #3223 )
...
* transfer plugin
Signed-off-by: Chris O'Haver <cohaver@infoblox.com >
2019-11-01 12:02:43 -04:00
