Chris O'Haver
158ad2d738
plugin/file/auto: Write CNAME answer to client even if target lookup is SERVFAIL ( #4863 )
...
* write cname answer to client even if target lookup is servfail
Signed-off-by: Chris O'Haver <cohaver@infoblox.com >
* fix existing unit test expectations
Signed-off-by: Chris O'Haver <cohaver@infoblox.com >
2021-09-14 10:08:22 +02:00
Chris O'Haver
6bbb48d403
plugin/file: Use NXDOMAIN response if CNAME target is NXDOMAIN ( #4303 )
...
* pass through nxdomain results
Signed-off-by: Chris O'Haver <cohaver@infoblox.com >
* return srvfail and nodata results
Signed-off-by: Chris O'Haver <cohaver@infoblox.com >
* add test
Signed-off-by: Chris O'Haver <cohaver@infoblox.com >
* cover more response cases
Signed-off-by: Chris O'Haver <cohaver@infoblox.com >
2020-12-09 09:44:31 +01:00
Yong Tang
9798dd067f
Cherry-pick: Implement notifies for transfer plugin ( #3972 ) ( #4142 )
...
* Implement notifies for transfer plugin (#3972 )
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* really fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* Add transfer tests
copied and modified from #3452
Signed-off-by: Miek Gieben <miek@miek.nl >
* Test correct selection of plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* add upstream back in
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* properly merge
Signed-off-by: Miek Gieben <miek@miek.nl >
* Remove plugin/kubernetes/setup_transfer_test.go
Signed-off-by: Yong Tang <yong.tang.github@outlook.com >
Co-authored-by: Miek Gieben <miek@miek.nl >
2020-09-24 20:30:39 +02:00
Yong Tang
614d08cba2
Revert "Implement notifies for transfer plugin ( #3972 )" ( #3995 )
...
This reverts commit 68f1dd5ddfyong.tang.github@outlook.com >
2020-07-08 09:00:26 -07:00
Miek Gieben
68f1dd5ddf
Implement notifies for transfer plugin ( #3972 )
...
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* really fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* Add transfer tests
copied and modified from #3452
Signed-off-by: Miek Gieben <miek@miek.nl >
* Test correct selection of plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* add upstream back in
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* properly merge
Signed-off-by: Miek Gieben <miek@miek.nl >
2020-07-07 12:38:07 -07:00
Ambrose Chua
ed1f42cf56
Fix mixed indentation within tests ( #3855 )
...
Signed-off-by: Ambrose Chua <ambrose@chua.family >
2020-04-25 08:08:36 +02:00
Xuanwo
ffe79b026e
Remove duplicated TempFile testsuit ( #2508 )
2019-01-28 07:25:14 +00:00
Miek Gieben
26c41a0c17
plugin/file: fix local CNAME lookup ( #1866 )
...
* plugin/file: fix local CNAME lookup
Issue #1864 explains it will, when we serve the child zone as well we
should just recursive into ourself (upstream self). Thus relax the
IsSubDomain check in file/lookup.go and just query (even if the query
will hit a remote server).
I've looped over all other plugins that do something similar (CNAME
resolving) and they didn't do the IsSubDomain check; therefor I've
removed it from *file* as well.
Added test in file_upstream_test that shows this failed before but now
results in a reply.
Fixes #1864
* self does not need to be exported
* Fix test
We don't know if we had a valid reply. Check this.
2018-06-12 14:54:37 +01:00
Miek Gieben
1ae8a9e321
Add upstream unit test ( #1830 )
...
Fix the upstream unit test to actually test it.
2018-05-23 21:31:54 +01:00
Miek Gieben
0f74281a53
Revert pkg/nonwriter changes ( #1829 )
...
The DoH work (#1619 ) made changes to pkg/nonwriter.Writer that in
hindsight were not backwards compatible; it added override for the
LocalAddr() and RemoteAddr(). Instead of rolling back that PR, this PR
reverts those changes and creates a DoHWriter for use in the
https-server.go side of things.
This was only caught in the integration test making this hard to catch,
so we add a upstream_file_test.go that tries (doesn't work yet) to test
this in the unit tests as well. Esp. helpful when 'git bisecting'.
Fixes #1826
2018-05-23 08:50:27 -04:00
