Ville Vesilehto
c916cf4259
fix(plugin): nilness findings ( #7556 )
...
Enable nilness linter in govet.
Plugin-by-plugin rationale:
- plugin/transfer: reuse error instead of shadowing it inside the for
loop by declaring "ret" outside of the loop
- plugin/view: remove redundant err check
- plugin/dnstap: avoid possible nil dereference in error reporting
path in setup test
- plugin/forward: prevent nil deference or empty-slice dereference on
error paths in setup test
Signed-off-by: Ville Vesilehto <ville@vesilehto.fi >
2025-09-15 10:17:06 -07:00
Ville Vesilehto
19a6ae4983
lint: enable intrange linter ( #7331 )
...
Enable intrange linter to enforce modern Go range syntax over
traditional for loops, by converting:
for i := 0; i < n; i++
to:
for i := range n
Adding type conversions where needed for compatibility
with existing uint64 parameters.
Signed-off-by: Ville Vesilehto <ville@vesilehto.fi >
2025-05-28 17:50:55 -07:00
Chris O'Haver
77c7c0b4cb
send notifies after adding zones all zones ( #5774 )
...
Signed-off-by: Chris O'Haver <cohaver@infoblox.com >
2023-02-15 13:25:02 -05:00
Yong Tang
9798dd067f
Cherry-pick: Implement notifies for transfer plugin ( #3972 ) ( #4142 )
...
* Implement notifies for transfer plugin (#3972 )
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* really fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* Add transfer tests
copied and modified from #3452
Signed-off-by: Miek Gieben <miek@miek.nl >
* Test correct selection of plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* add upstream back in
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* properly merge
Signed-off-by: Miek Gieben <miek@miek.nl >
* Remove plugin/kubernetes/setup_transfer_test.go
Signed-off-by: Yong Tang <yong.tang.github@outlook.com >
Co-authored-by: Miek Gieben <miek@miek.nl >
2020-09-24 20:30:39 +02:00
Yong Tang
614d08cba2
Revert "Implement notifies for transfer plugin ( #3972 )" ( #3995 )
...
This reverts commit 68f1dd5ddfyong.tang.github@outlook.com >
2020-07-08 09:00:26 -07:00
Miek Gieben
68f1dd5ddf
Implement notifies for transfer plugin ( #3972 )
...
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl >
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl >
* golint
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl >
* really fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* Add transfer tests
copied and modified from #3452
Signed-off-by: Miek Gieben <miek@miek.nl >
* Test correct selection of plugin
Signed-off-by: Miek Gieben <miek@miek.nl >
* add upstream back in
Signed-off-by: Miek Gieben <miek@miek.nl >
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl >
* fix test
Signed-off-by: Miek Gieben <miek@miek.nl >
* properly merge
Signed-off-by: Miek Gieben <miek@miek.nl >
2020-07-07 12:38:07 -07:00
