unsure why this only pops up, but the yaml was not correct for this
workflow. Randomly added whitespace until it parsed as proper yaml
Signed-off-by: Miek Gieben <miek@miek.nl>
This PR switches from actions/setup-go@v2-beta to actions/setup-go@v2 to fix the
GitHub Actions `set-env` failure. Without this PR the following error shown up
(see https://github.com/coredns/coredns/runs/1423802307):
```
Error: Unable to process command '::set-env name=GOROOT::/opt/hostedtoolcache/go/1.15.5/x64' successfully.
7
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
```
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Looks like one `*` is missing in Go Fmt GitHub Actions
and that causes the Actions not being triggered.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Setup GitHub Actions for auto remove trailing whitespaces
This PR setup GitHub Actions for auto remove trailing whitespaces,
if any non-go files are touched (.git directory are ignored)
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Remove TestTrailingWhitespace in presubmit tests
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* paths and paths-ignore are mutually exlcusive so only keep paths-ignore
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Remove redundent bufio import
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Add GitHub Actions to `gofmt -s -w` all `*.go` files
This PR adds GitHub Actions to `gofmt -s -w` all `*.go` files,
if any `*.go` files are touched on each commit.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
* Change go-mod-fmt to go-fmt
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Add github testing workflow, simplify the Makefile because that was
complex because of Travis. Remove the fuzzing, needs to be re-added when
that works properly with go modules (it has been disabled for quite some
time). Multiple builds and files have been added so these tests can all
run in parallel. Our testing now tests a couple of minutes, the codeql
is by far the more expensive.
Move metric's naming test to test/presubmit_test.go
Add longer sleep in the TestAutoAXFR.
Bye bye travis!
Closes: #4266
Signed-off-by: Miek Gieben <miek@miek.nl>
We get many questions (which is fine), but those are neither a bug, nor
an enhancement. Just add generic question as an option.
Signed-off-by: Miek Gieben <miek@miek.nl>
This PR updates go.tidy.yml, and use pseudo name
`coredns-auto-go-mod-tidy[bot]`, so that the commit
is not associated with real user. Otherwise
the commit history could be confusing.
This is similar to what `dependabot[bot]` is doing
for commits generated by bots.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Setup GitHub Workflow for auto `go tidy`, when
- 'go.mod'
- 'go.sum'
- '.github/workflows/go.tidy.yml'
has been touched.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
An ISSUE_TEMPLATE directory was added, meaning the ISSUE_TEMPLATE.md is
now obsolete. Remove stale.yml because not used. Symlink CONTRIBUTING.md
the other way around to get GitHub recognize it.
Signed-off-by: Miek Gieben <miek@miek.nl>
symlink from within .github
This should be enough to show it in pull request; unless github has
something against symlinks.
Signed-off-by: Miek Gieben <miek@miek.nl>
* stalebot: use wontfix-stalebot
I've added two new labels: wontfix-stalebot and pinned.
Wontfix-stalebot will be used by stalebot and pinned can be used to keep
issues open.
* later as well
