mirror of
https://github.com/coredns/coredns.git
synced 2025-10-27 08:14:18 -04:00
c916cf4259
Enable nilness linter in govet. Plugin-by-plugin rationale: - plugin/transfer: reuse error instead of shadowing it inside the for loop by declaring "ret" outside of the loop - plugin/view: remove redundant err check - plugin/dnstap: avoid possible nil dereference in error reporting path in setup test - plugin/forward: prevent nil deference or empty-slice dereference on error paths in setup test Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
60 lines
1.3 KiB
Go
60 lines
1.3 KiB
Go
package transfer
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/coredns/coredns/plugin/pkg/rcode"
|
|
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
// Notify will send notifies to all configured to hosts IP addresses. The string zone must be lowercased.
|
|
func (t *Transfer) Notify(zone string) error {
|
|
if t == nil { // t might be nil, mostly expected in tests, so intercept and to a noop in that case
|
|
return nil
|
|
}
|
|
|
|
m := new(dns.Msg)
|
|
m.SetNotify(zone)
|
|
c := new(dns.Client)
|
|
|
|
x := longestMatch(t.xfrs, zone)
|
|
if x == nil {
|
|
// return without error if there is no matching zone
|
|
return nil
|
|
}
|
|
|
|
var err1 error
|
|
for _, t := range x.to {
|
|
if t == "*" {
|
|
continue
|
|
}
|
|
if err := sendNotify(c, m, t); err != nil {
|
|
err1 = err
|
|
}
|
|
}
|
|
log.Debugf("Sent notifies for zone %q to %v", zone, x.to)
|
|
return err1 // this only captures the last error
|
|
}
|
|
|
|
func sendNotify(c *dns.Client, m *dns.Msg, s string) error {
|
|
var err error
|
|
var ret *dns.Msg
|
|
|
|
code := dns.RcodeServerFailure
|
|
for range 3 {
|
|
ret, _, err = c.Exchange(m, s)
|
|
if err != nil {
|
|
continue
|
|
}
|
|
code = ret.Rcode
|
|
if code == dns.RcodeSuccess {
|
|
return nil
|
|
}
|
|
}
|
|
if err != nil {
|
|
return fmt.Errorf("notify for zone %q was not accepted by %q: %q", m.Question[0].Name, s, err)
|
|
}
|
|
return fmt.Errorf("notify for zone %q was not accepted by %q: rcode was %q", m.Question[0].Name, s, rcode.ToString(code))
|
|
}
|