mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-29 17:24:20 -04:00 
			
		
		
		
	Cache the size and the do bit whenever someone asked for it. We can probably add more: PASS BenchmarkStateDo-4 100000000 11.9 ns/op BenchmarkStateSize-4 5000000 265 ns/op ok github.com/miekg/coredns/middleware 2.828s PASS BenchmarkStateDo-4 1000000000 2.86 ns/op BenchmarkStateSize-4 500000000 3.10 ns/op ok github.com/miekg/coredns/middleware 5.032s This PR also includes some testing cleanups as well.
		
			
				
	
	
		
			224 lines
		
	
	
		
			6.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			224 lines
		
	
	
		
			6.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package testing
 | |
| 
 | |
| import (
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/miekg/dns"
 | |
| 	"golang.org/x/net/context"
 | |
| )
 | |
| 
 | |
| type Sect int
 | |
| 
 | |
| const (
 | |
| 	Answer Sect = iota
 | |
| 	Ns
 | |
| 	Extra
 | |
| )
 | |
| 
 | |
| type RRSet []dns.RR
 | |
| 
 | |
| func (p RRSet) Len() int           { return len(p) }
 | |
| func (p RRSet) Swap(i, j int)      { p[i], p[j] = p[j], p[i] }
 | |
| func (p RRSet) Less(i, j int) bool { return p[i].String() < p[j].String() }
 | |
| 
 | |
| type Case struct {
 | |
| 	Qname  string
 | |
| 	Qtype  uint16
 | |
| 	Rcode  int
 | |
| 	Do     bool
 | |
| 	Answer []dns.RR
 | |
| 	Ns     []dns.RR
 | |
| 	Extra  []dns.RR
 | |
| }
 | |
| 
 | |
| func (c Case) Msg() *dns.Msg {
 | |
| 	m := new(dns.Msg)
 | |
| 	m.SetQuestion(dns.Fqdn(c.Qname), c.Qtype)
 | |
| 	if c.Do {
 | |
| 		o := new(dns.OPT)
 | |
| 		o.Hdr.Name = "."
 | |
| 		o.Hdr.Rrtype = dns.TypeOPT
 | |
| 		o.SetDo()
 | |
| 		o.SetUDPSize(4096)
 | |
| 		m.Extra = []dns.RR{o}
 | |
| 	}
 | |
| 	return m
 | |
| }
 | |
| 
 | |
| func A(rr string) *dns.A         { r, _ := dns.NewRR(rr); return r.(*dns.A) }
 | |
| func AAAA(rr string) *dns.AAAA   { r, _ := dns.NewRR(rr); return r.(*dns.AAAA) }
 | |
| func CNAME(rr string) *dns.CNAME { r, _ := dns.NewRR(rr); return r.(*dns.CNAME) }
 | |
| func SRV(rr string) *dns.SRV     { r, _ := dns.NewRR(rr); return r.(*dns.SRV) }
 | |
| func SOA(rr string) *dns.SOA     { r, _ := dns.NewRR(rr); return r.(*dns.SOA) }
 | |
| func NS(rr string) *dns.NS       { r, _ := dns.NewRR(rr); return r.(*dns.NS) }
 | |
| func PTR(rr string) *dns.PTR     { r, _ := dns.NewRR(rr); return r.(*dns.PTR) }
 | |
| func TXT(rr string) *dns.TXT     { r, _ := dns.NewRR(rr); return r.(*dns.TXT) }
 | |
| func MX(rr string) *dns.MX       { r, _ := dns.NewRR(rr); return r.(*dns.MX) }
 | |
| func RRSIG(rr string) *dns.RRSIG { r, _ := dns.NewRR(rr); return r.(*dns.RRSIG) }
 | |
| func NSEC(rr string) *dns.NSEC   { r, _ := dns.NewRR(rr); return r.(*dns.NSEC) }
 | |
| 
 | |
| func Header(t *testing.T, tc Case, resp *dns.Msg) bool {
 | |
| 	if resp.Rcode != tc.Rcode {
 | |
| 		t.Errorf("rcode is %q, expected %q", dns.RcodeToString[resp.Rcode], dns.RcodeToString[tc.Rcode])
 | |
| 		return false
 | |
| 	}
 | |
| 
 | |
| 	if len(resp.Answer) != len(tc.Answer) {
 | |
| 		t.Errorf("answer for %q contained %d results, %d expected", tc.Qname, len(resp.Answer), len(tc.Answer))
 | |
| 		return false
 | |
| 	}
 | |
| 	if len(resp.Ns) != len(tc.Ns) {
 | |
| 		t.Errorf("authority for %q contained %d results, %d expected", tc.Qname, len(resp.Ns), len(tc.Ns))
 | |
| 		return false
 | |
| 	}
 | |
| 	if len(resp.Extra) != len(tc.Extra) {
 | |
| 		t.Errorf("additional for %q contained %d results, %d expected", tc.Qname, len(resp.Extra), len(tc.Extra))
 | |
| 		return false
 | |
| 	}
 | |
| 	return true
 | |
| }
 | |
| 
 | |
| func Section(t *testing.T, tc Case, sect Sect, rr []dns.RR) bool {
 | |
| 	section := []dns.RR{}
 | |
| 	switch sect {
 | |
| 	case 0:
 | |
| 		section = tc.Answer
 | |
| 	case 1:
 | |
| 		section = tc.Ns
 | |
| 	case 2:
 | |
| 		section = tc.Extra
 | |
| 	}
 | |
| 
 | |
| 	for i, a := range rr {
 | |
| 		if a.Header().Name != section[i].Header().Name {
 | |
| 			t.Errorf("rr %d should have a Header Name of %q, but has %q", i, section[i].Header().Name, a.Header().Name)
 | |
| 			return false
 | |
| 		}
 | |
| 		// 303 signals: don't care what the ttl is.
 | |
| 		if section[i].Header().Ttl != 303 && a.Header().Ttl != section[i].Header().Ttl {
 | |
| 			t.Errorf("rr %d should have a Header TTL of %d, but has %d", i, section[i].Header().Ttl, a.Header().Ttl)
 | |
| 			return false
 | |
| 		}
 | |
| 		if a.Header().Rrtype != section[i].Header().Rrtype {
 | |
| 			t.Errorf("rr %d should have a header rr type of %d, but has %d", i, section[i].Header().Rrtype, a.Header().Rrtype)
 | |
| 			return false
 | |
| 		}
 | |
| 
 | |
| 		switch x := a.(type) {
 | |
| 		case *dns.SRV:
 | |
| 			if x.Priority != section[i].(*dns.SRV).Priority {
 | |
| 				t.Errorf("rr %d should have a Priority of %d, but has %d", i, section[i].(*dns.SRV).Priority, x.Priority)
 | |
| 				return false
 | |
| 			}
 | |
| 			if x.Weight != section[i].(*dns.SRV).Weight {
 | |
| 				t.Errorf("rr %d should have a Weight of %d, but has %d", i, section[i].(*dns.SRV).Weight, x.Weight)
 | |
| 				return false
 | |
| 			}
 | |
| 			if x.Port != section[i].(*dns.SRV).Port {
 | |
| 				t.Errorf("rr %d should have a Port of %d, but has %d", i, section[i].(*dns.SRV).Port, x.Port)
 | |
| 				return false
 | |
| 			}
 | |
| 			if x.Target != section[i].(*dns.SRV).Target {
 | |
| 				t.Errorf("rr %d should have a Target of %q, but has %q", i, section[i].(*dns.SRV).Target, x.Target)
 | |
| 				return false
 | |
| 			}
 | |
| 		case *dns.RRSIG:
 | |
| 			if x.TypeCovered != section[i].(*dns.RRSIG).TypeCovered {
 | |
| 				t.Errorf("rr %d should have a TypeCovered of %d, but has %d", i, section[i].(*dns.RRSIG).TypeCovered, x.TypeCovered)
 | |
| 				return false
 | |
| 			}
 | |
| 			if x.Labels != section[i].(*dns.RRSIG).Labels {
 | |
| 				t.Errorf("rr %d should have a Labels of %d, but has %d", i, section[i].(*dns.RRSIG).Labels, x.Labels)
 | |
| 				return false
 | |
| 			}
 | |
| 			if x.SignerName != section[i].(*dns.RRSIG).SignerName {
 | |
| 				t.Errorf("rr %d should have a SignerName of %d, but has %d", i, section[i].(*dns.RRSIG).SignerName, x.SignerName)
 | |
| 				return false
 | |
| 			}
 | |
| 		case *dns.NSEC:
 | |
| 			if x.NextDomain != section[i].(*dns.NSEC).NextDomain {
 | |
| 				t.Errorf("rr %d should have a NextDomain of %d, but has %d", i, section[i].(*dns.NSEC).NextDomain, x.NextDomain)
 | |
| 				return false
 | |
| 			}
 | |
| 			// TypeBitMap
 | |
| 		case *dns.A:
 | |
| 			if x.A.String() != section[i].(*dns.A).A.String() {
 | |
| 				t.Errorf("rr %d should have a Address of %q, but has %q", i, section[i].(*dns.A).A.String(), x.A.String())
 | |
| 				return false
 | |
| 			}
 | |
| 		case *dns.AAAA:
 | |
| 			if x.AAAA.String() != section[i].(*dns.AAAA).AAAA.String() {
 | |
| 				t.Errorf("rr %d should have a Address of %q, but has %q", i, section[i].(*dns.AAAA).AAAA.String(), x.AAAA.String())
 | |
| 				return false
 | |
| 			}
 | |
| 		case *dns.TXT:
 | |
| 			for j, txt := range x.Txt {
 | |
| 				if txt != section[i].(*dns.TXT).Txt[j] {
 | |
| 					t.Errorf("rr %d should have a Txt of %q, but has %q", i, section[i].(*dns.TXT).Txt[j], txt)
 | |
| 					return false
 | |
| 				}
 | |
| 			}
 | |
| 		case *dns.SOA:
 | |
| 			tt := section[i].(*dns.SOA)
 | |
| 			if x.Ns != tt.Ns {
 | |
| 				t.Errorf("SOA nameserver should be %q, but is %q", x.Ns, tt.Ns)
 | |
| 				return false
 | |
| 			}
 | |
| 		case *dns.PTR:
 | |
| 			tt := section[i].(*dns.PTR)
 | |
| 			if x.Ptr != tt.Ptr {
 | |
| 				t.Errorf("PTR ptr should be %q, but is %q", x.Ptr, tt.Ptr)
 | |
| 				return false
 | |
| 			}
 | |
| 		case *dns.CNAME:
 | |
| 			tt := section[i].(*dns.CNAME)
 | |
| 			if x.Target != tt.Target {
 | |
| 				t.Errorf("CNAME target should be %q, but is %q", x.Target, tt.Target)
 | |
| 				return false
 | |
| 			}
 | |
| 		case *dns.MX:
 | |
| 			tt := section[i].(*dns.MX)
 | |
| 			if x.Mx != tt.Mx {
 | |
| 				t.Errorf("MX Mx should be %q, but is %q", x.Mx, tt.Mx)
 | |
| 				return false
 | |
| 			}
 | |
| 			if x.Preference != tt.Preference {
 | |
| 				t.Errorf("MX Preference should be %q, but is %q", x.Preference, tt.Preference)
 | |
| 				return false
 | |
| 			}
 | |
| 		case *dns.NS:
 | |
| 			tt := section[i].(*dns.NS)
 | |
| 			if x.Ns != tt.Ns {
 | |
| 				t.Errorf("NS nameserver should be %q, but is %q", x.Ns, tt.Ns)
 | |
| 				return false
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| 	return true
 | |
| }
 | |
| 
 | |
| func ErrorHandler() Handler {
 | |
| 	return HandlerFunc(func(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
 | |
| 		m := new(dns.Msg)
 | |
| 		m.SetRcode(r, dns.RcodeServerFailure)
 | |
| 		w.WriteMsg(m)
 | |
| 		return dns.RcodeServerFailure, nil
 | |
| 	})
 | |
| }
 | |
| 
 | |
| // Copied here to prevent an import cycle.
 | |
| type (
 | |
| 	// HandlerFunc is a convenience type like dns.HandlerFunc, except
 | |
| 	// ServeDNS returns an rcode and an error.
 | |
| 	HandlerFunc func(context.Context, dns.ResponseWriter, *dns.Msg) (int, error)
 | |
| 
 | |
| 	Handler interface {
 | |
| 		ServeDNS(context.Context, dns.ResponseWriter, *dns.Msg) (int, error)
 | |
| 	}
 | |
| )
 | |
| 
 | |
| // ServeDNS implements the Handler interface.
 | |
| func (f HandlerFunc) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
 | |
| 	return f(ctx, w, r)
 | |
| }
 |