mirror of
https://github.com/coredns/coredns.git
synced 2025-11-03 10:43:20 -05:00
c840caf1ef
* Speed up testing * make notification run in the background, this recudes the test_readme time from 18s to 0.10s * reduce time for zone reload * TestServeDNSConcurrent remove entirely. This took a whopping 58s for ... ? A few minutes staring didn't reveal wth it is actually testing. Making values smaller revealed race conditions in the tests. Remove entirely. * Move many interval values to variables so we can reset them to short values for the tests. * test_large_axfr: make the zone smaller. The number used 64K has no rational, make it 64/10 to speed up. * TestProxyThreeWay: use client with shorter timeout A few random tidbits in other tests. Total time saved: 177s (almost 3m) - which makes it worthwhile again to run the test locally: this branch: ~~~ ok github.com/coredns/coredns/test 10.437s cd plugin; time go t ./... 5,51s user 7,51s system 11,15s elapsed 744%CPU ( ~~~ master: ~~~ ok github.com/coredns/coredns/test 35.252s cd plugin; time go t ./... 157,64s user 15,39s system 50,05s elapsed 345%CPU () ~~~ tests/ -25s plugins/ -40s This brings the total on 20s, and another 10s can be saved by fixing dnstapio. Moving this to 5s would be even better, but 10s is also nice. Signed-off-by: Miek Gieben <miek@miek.nl> * Also 0.01 Signed-off-by: Miek Gieben <miek@miek.nl>
83 lines
1.9 KiB
Go
83 lines
1.9 KiB
Go
package metrics
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/coredns/coredns/plugin"
|
|
"github.com/coredns/coredns/plugin/pkg/dnstest"
|
|
"github.com/coredns/coredns/plugin/test"
|
|
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
func TestMetrics(t *testing.T) {
|
|
met := New("localhost:0")
|
|
if err := met.OnStartup(); err != nil {
|
|
t.Fatalf("Failed to start metrics handler: %s", err)
|
|
}
|
|
defer met.OnFinalShutdown()
|
|
|
|
met.AddZone("example.org.")
|
|
|
|
tests := []struct {
|
|
next plugin.Handler
|
|
qname string
|
|
qtype uint16
|
|
metric string
|
|
expectedValue string
|
|
}{
|
|
// This all works because 1 bucket (1 zone, 1 type)
|
|
{
|
|
next: test.NextHandler(dns.RcodeSuccess, nil),
|
|
qname: "example.org.",
|
|
metric: "coredns_dns_requests_total",
|
|
expectedValue: "1",
|
|
},
|
|
{
|
|
next: test.NextHandler(dns.RcodeSuccess, nil),
|
|
qname: "example.org.",
|
|
metric: "coredns_dns_requests_total",
|
|
expectedValue: "2",
|
|
},
|
|
{
|
|
next: test.NextHandler(dns.RcodeSuccess, nil),
|
|
qname: "example.org.",
|
|
metric: "coredns_dns_requests_total",
|
|
expectedValue: "3",
|
|
},
|
|
{
|
|
next: test.NextHandler(dns.RcodeSuccess, nil),
|
|
qname: "example.org.",
|
|
metric: "coredns_dns_responses_total",
|
|
expectedValue: "4",
|
|
},
|
|
}
|
|
|
|
ctx := context.TODO()
|
|
|
|
for i, tc := range tests {
|
|
req := new(dns.Msg)
|
|
if tc.qtype == 0 {
|
|
tc.qtype = dns.TypeA
|
|
}
|
|
req.SetQuestion(tc.qname, tc.qtype)
|
|
met.Next = tc.next
|
|
|
|
rec := dnstest.NewRecorder(&test.ResponseWriter{})
|
|
_, err := met.ServeDNS(ctx, rec, req)
|
|
if err != nil {
|
|
t.Fatalf("Test %d: Expected no error, but got %s", i, err)
|
|
}
|
|
|
|
result := test.Scrape("http://" + ListenAddr + "/metrics")
|
|
|
|
if tc.expectedValue != "" {
|
|
got, _ := test.MetricValue(tc.metric, result)
|
|
if got != tc.expectedValue {
|
|
t.Errorf("Test %d: Expected value %s for metrics %s, but got %s", i, tc.expectedValue, tc.metric, got)
|
|
}
|
|
}
|
|
}
|
|
}
|