mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-29 01:04:15 -04:00 
			
		
		
		
	* plugin/forward: convert the specified domain of health_check to Fqdn * plugin/forward: update readme for health check Signed-off-by: vanceli <vanceli@tencent.com>
		
			
				
	
	
		
			335 lines
		
	
	
		
			12 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			335 lines
		
	
	
		
			12 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package forward
 | |
| 
 | |
| import (
 | |
| 	"os"
 | |
| 	"reflect"
 | |
| 	"strings"
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/coredns/caddy"
 | |
| 	"github.com/coredns/coredns/core/dnsserver"
 | |
| 
 | |
| 	"github.com/miekg/dns"
 | |
| )
 | |
| 
 | |
| func TestSetup(t *testing.T) {
 | |
| 	tests := []struct {
 | |
| 		input           string
 | |
| 		shouldErr       bool
 | |
| 		expectedFrom    string
 | |
| 		expectedIgnored []string
 | |
| 		expectedFails   uint32
 | |
| 		expectedOpts    options
 | |
| 		expectedErr     string
 | |
| 	}{
 | |
| 		// positive
 | |
| 		{"forward . 127.0.0.1", false, ".", nil, 2, options{hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check 0.5s domain example.org\n}\n", false, ".", nil, 2, options{hcRecursionDesired: true, hcDomain: "example.org."}, ""},
 | |
| 		{"forward . 127.0.0.1 {\nexcept miek.nl\n}\n", false, ".", nil, 2, options{hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{"forward . 127.0.0.1 {\nmax_fails 3\n}\n", false, ".", nil, 3, options{hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{"forward . 127.0.0.1 {\nforce_tcp\n}\n", false, ".", nil, 2, options{forceTCP: true, hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{"forward . 127.0.0.1 {\nprefer_udp\n}\n", false, ".", nil, 2, options{preferUDP: true, hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{"forward . 127.0.0.1 {\nforce_tcp\nprefer_udp\n}\n", false, ".", nil, 2, options{preferUDP: true, forceTCP: true, hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{"forward . 127.0.0.1:53", false, ".", nil, 2, options{hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{"forward . 127.0.0.1:8080", false, ".", nil, 2, options{hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{"forward . [::1]:53", false, ".", nil, 2, options{hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{"forward . [2003::1]:53", false, ".", nil, 2, options{hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{"forward . 127.0.0.1 \n", false, ".", nil, 2, options{hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{"forward 10.9.3.0/18 127.0.0.1", false, "0.9.10.in-addr.arpa.", nil, 2, options{hcRecursionDesired: true, hcDomain: "."}, ""},
 | |
| 		{`forward . ::1
 | |
| 		forward com ::2`, false, ".", nil, 2, options{hcRecursionDesired: true, hcDomain: "."}, "plugin"},
 | |
| 		// negative
 | |
| 		{"forward . a27.0.0.1", true, "", nil, 0, options{hcRecursionDesired: true, hcDomain: "."}, "not an IP"},
 | |
| 		{"forward . 127.0.0.1 {\nblaatl\n}\n", true, "", nil, 0, options{hcRecursionDesired: true, hcDomain: "."}, "unknown property"},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check 0.5s domain\n}\n", true, "", nil, 0, options{hcRecursionDesired: true, hcDomain: "."}, "Wrong argument count or unexpected line ending after 'domain'"},
 | |
| 		{"forward . https://127.0.0.1 \n", true, ".", nil, 2, options{hcRecursionDesired: true, hcDomain: "."}, "'https' is not supported as a destination protocol in forward: https://127.0.0.1"},
 | |
| 		{"forward xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx 127.0.0.1 \n", true, ".", nil, 2, options{hcRecursionDesired: true, hcDomain: "."}, "unable to normalize 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx'"},
 | |
| 	}
 | |
| 
 | |
| 	for i, test := range tests {
 | |
| 		c := caddy.NewTestController("dns", test.input)
 | |
| 		fs, err := parseForward(c)
 | |
| 
 | |
| 		if test.shouldErr && err == nil {
 | |
| 			t.Errorf("Test %d: expected error but found %s for input %s", i, err, test.input)
 | |
| 		}
 | |
| 
 | |
| 		if err != nil {
 | |
| 			if !test.shouldErr {
 | |
| 				t.Fatalf("Test %d: expected no error but found one for input %s, got: %v", i, test.input, err)
 | |
| 			}
 | |
| 
 | |
| 			if !strings.Contains(err.Error(), test.expectedErr) {
 | |
| 				t.Errorf("Test %d: expected error to contain: %v, found error: %v, input: %s", i, test.expectedErr, err, test.input)
 | |
| 			}
 | |
| 		}
 | |
| 
 | |
| 		if !test.shouldErr {
 | |
| 			f := fs[0]
 | |
| 			if f.from != test.expectedFrom {
 | |
| 				t.Errorf("Test %d: expected: %s, got: %s", i, test.expectedFrom, f.from)
 | |
| 			}
 | |
| 			if test.expectedIgnored != nil {
 | |
| 				if !reflect.DeepEqual(f.ignored, test.expectedIgnored) {
 | |
| 					t.Errorf("Test %d: expected: %q, actual: %q", i, test.expectedIgnored, f.ignored)
 | |
| 				}
 | |
| 			}
 | |
| 			if f.maxfails != test.expectedFails {
 | |
| 				t.Errorf("Test %d: expected: %d, got: %d", i, test.expectedFails, f.maxfails)
 | |
| 			}
 | |
| 			if f.opts != test.expectedOpts {
 | |
| 				t.Errorf("Test %d: expected: %v, got: %v", i, test.expectedOpts, f.opts)
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestSetupTLS(t *testing.T) {
 | |
| 	tests := []struct {
 | |
| 		input              string
 | |
| 		shouldErr          bool
 | |
| 		expectedServerName string
 | |
| 		expectedErr        string
 | |
| 	}{
 | |
| 		// positive
 | |
| 		{`forward . tls://127.0.0.1 {
 | |
| 				tls_servername dns
 | |
| 			}`, false, "dns", ""},
 | |
| 		{`forward . 127.0.0.1 {
 | |
| 				tls_servername dns
 | |
| 			}`, false, "", ""},
 | |
| 		{`forward . 127.0.0.1 {
 | |
| 				tls
 | |
| 			}`, false, "", ""},
 | |
| 		{`forward . tls://127.0.0.1`, false, "", ""},
 | |
| 	}
 | |
| 
 | |
| 	for i, test := range tests {
 | |
| 		c := caddy.NewTestController("dns", test.input)
 | |
| 		fs, err := parseForward(c)
 | |
| 		f := fs[0]
 | |
| 
 | |
| 		if test.shouldErr && err == nil {
 | |
| 			t.Errorf("Test %d: expected error but found %s for input %s", i, err, test.input)
 | |
| 		}
 | |
| 
 | |
| 		if err != nil {
 | |
| 			if !test.shouldErr {
 | |
| 				t.Errorf("Test %d: expected no error but found one for input %s, got: %v", i, test.input, err)
 | |
| 			}
 | |
| 
 | |
| 			if !strings.Contains(err.Error(), test.expectedErr) {
 | |
| 				t.Errorf("Test %d: expected error to contain: %v, found error: %v, input: %s", i, test.expectedErr, err, test.input)
 | |
| 			}
 | |
| 		}
 | |
| 
 | |
| 		if !test.shouldErr && test.expectedServerName != "" && test.expectedServerName != f.tlsConfig.ServerName {
 | |
| 			t.Errorf("Test %d: expected: %q, actual: %q", i, test.expectedServerName, f.tlsConfig.ServerName)
 | |
| 		}
 | |
| 
 | |
| 		if !test.shouldErr && test.expectedServerName != "" && test.expectedServerName != f.proxies[0].health.(*dnsHc).c.TLSConfig.ServerName {
 | |
| 			t.Errorf("Test %d: expected: %q, actual: %q", i, test.expectedServerName, f.proxies[0].health.(*dnsHc).c.TLSConfig.ServerName)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestSetupResolvconf(t *testing.T) {
 | |
| 	const resolv = "resolv.conf"
 | |
| 	if err := os.WriteFile(resolv,
 | |
| 		[]byte(`nameserver 10.10.255.252
 | |
| nameserver 10.10.255.253`), 0666); err != nil {
 | |
| 		t.Fatalf("Failed to write resolv.conf file: %s", err)
 | |
| 	}
 | |
| 	defer os.Remove(resolv)
 | |
| 
 | |
| 	tests := []struct {
 | |
| 		input         string
 | |
| 		shouldErr     bool
 | |
| 		expectedErr   string
 | |
| 		expectedNames []string
 | |
| 	}{
 | |
| 		// pass
 | |
| 		{`forward . ` + resolv, false, "", []string{"10.10.255.252:53", "10.10.255.253:53"}},
 | |
| 		// fail
 | |
| 		{`forward . /dev/null`, true, "no nameservers", nil},
 | |
| 	}
 | |
| 
 | |
| 	for i, test := range tests {
 | |
| 		c := caddy.NewTestController("dns", test.input)
 | |
| 		fs, err := parseForward(c)
 | |
| 
 | |
| 		if test.shouldErr && err == nil {
 | |
| 			t.Errorf("Test %d: expected error but found %s for input %s", i, err, test.input)
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		if err != nil {
 | |
| 			if !test.shouldErr {
 | |
| 				t.Errorf("Test %d: expected no error but found one for input %s, got: %v", i, test.input, err)
 | |
| 			}
 | |
| 
 | |
| 			if !strings.Contains(err.Error(), test.expectedErr) {
 | |
| 				t.Errorf("Test %d: expected error to contain: %v, found error: %v, input: %s", i, test.expectedErr, err, test.input)
 | |
| 			}
 | |
| 		}
 | |
| 
 | |
| 		if test.shouldErr {
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		f := fs[0]
 | |
| 		for j, n := range test.expectedNames {
 | |
| 			addr := f.proxies[j].addr
 | |
| 			if n != addr {
 | |
| 				t.Errorf("Test %d, expected %q, got %q", j, n, addr)
 | |
| 			}
 | |
| 		}
 | |
| 
 | |
| 		for _, p := range f.proxies {
 | |
| 			p.health.Check(p) // this should almost always err, we don't care it shouldn't crash
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestSetupMaxConcurrent(t *testing.T) {
 | |
| 	tests := []struct {
 | |
| 		input       string
 | |
| 		shouldErr   bool
 | |
| 		expectedVal int64
 | |
| 		expectedErr string
 | |
| 	}{
 | |
| 		// positive
 | |
| 		{"forward . 127.0.0.1 {\nmax_concurrent 1000\n}\n", false, 1000, ""},
 | |
| 		// negative
 | |
| 		{"forward . 127.0.0.1 {\nmax_concurrent many\n}\n", true, 0, "invalid"},
 | |
| 		{"forward . 127.0.0.1 {\nmax_concurrent -4\n}\n", true, 0, "negative"},
 | |
| 	}
 | |
| 
 | |
| 	for i, test := range tests {
 | |
| 		c := caddy.NewTestController("dns", test.input)
 | |
| 		fs, err := parseForward(c)
 | |
| 
 | |
| 		if test.shouldErr && err == nil {
 | |
| 			t.Errorf("Test %d: expected error but found %s for input %s", i, err, test.input)
 | |
| 		}
 | |
| 
 | |
| 		if err != nil {
 | |
| 			if !test.shouldErr {
 | |
| 				t.Errorf("Test %d: expected no error but found one for input %s, got: %v", i, test.input, err)
 | |
| 			}
 | |
| 
 | |
| 			if !strings.Contains(err.Error(), test.expectedErr) {
 | |
| 				t.Errorf("Test %d: expected error to contain: %v, found error: %v, input: %s", i, test.expectedErr, err, test.input)
 | |
| 			}
 | |
| 		}
 | |
| 
 | |
| 		if test.shouldErr {
 | |
| 			continue
 | |
| 		}
 | |
| 		f := fs[0]
 | |
| 		if f.maxConcurrent != test.expectedVal {
 | |
| 			t.Errorf("Test %d: expected: %d, got: %d", i, test.expectedVal, f.maxConcurrent)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestSetupHealthCheck(t *testing.T) {
 | |
| 	tests := []struct {
 | |
| 		input          string
 | |
| 		shouldErr      bool
 | |
| 		expectedRecVal bool
 | |
| 		expectedDomain string
 | |
| 		expectedErr    string
 | |
| 	}{
 | |
| 		// positive
 | |
| 		{"forward . 127.0.0.1\n", false, true, ".", ""},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check 0.5s\n}\n", false, true, ".", ""},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check 0.5s no_rec\n}\n", false, false, ".", ""},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check 0.5s no_rec domain example.org\n}\n", false, false, "example.org.", ""},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check 0.5s domain example.org\n}\n", false, true, "example.org.", ""},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check 0.5s domain .\n}\n", false, true, ".", ""},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check 0.5s domain example.org.\n}\n", false, true, "example.org.", ""},
 | |
| 		// negative
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check no_rec\n}\n", true, true, ".", "time: invalid duration"},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check domain example.org\n}\n", true, true, "example.org", "time: invalid duration"},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check 0.5s rec\n}\n", true, true, ".", "health_check: unknown option rec"},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check 0.5s domain\n}\n", true, true, ".", "Wrong argument count or unexpected line ending after 'domain'"},
 | |
| 		{"forward . 127.0.0.1 {\nhealth_check 0.5s domain example..org\n}\n", true, true, ".", "health_check: invalid domain name"},
 | |
| 	}
 | |
| 
 | |
| 	for i, test := range tests {
 | |
| 		c := caddy.NewTestController("dns", test.input)
 | |
| 		fs, err := parseForward(c)
 | |
| 
 | |
| 		if test.shouldErr && err == nil {
 | |
| 			t.Errorf("Test %d: expected error but found %s for input %s", i, err, test.input)
 | |
| 		}
 | |
| 
 | |
| 		if err != nil {
 | |
| 			if !test.shouldErr {
 | |
| 				t.Errorf("Test %d: expected no error but found one for input %s, got: %v", i, test.input, err)
 | |
| 			}
 | |
| 			if !strings.Contains(err.Error(), test.expectedErr) {
 | |
| 				t.Errorf("Test %d: expected error to contain: %v, found error: %v, input: %s", i, test.expectedErr, err, test.input)
 | |
| 			}
 | |
| 		}
 | |
| 
 | |
| 		if test.shouldErr {
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		f := fs[0]
 | |
| 		if f.opts.hcRecursionDesired != test.expectedRecVal || f.proxies[0].health.GetRecursionDesired() != test.expectedRecVal ||
 | |
| 			f.opts.hcDomain != test.expectedDomain || f.proxies[0].health.GetDomain() != test.expectedDomain || !dns.IsFqdn(f.proxies[0].health.GetDomain()) {
 | |
| 			t.Errorf("Test %d: expectedRec: %v, got: %v. expectedDomain: %s, got: %s. ", i, test.expectedRecVal, f.opts.hcRecursionDesired, test.expectedDomain, f.opts.hcDomain)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestMultiForward(t *testing.T) {
 | |
| 	input := `
 | |
|       forward 1st.example.org 10.0.0.1
 | |
|       forward 2nd.example.org 10.0.0.2
 | |
|       forward 3rd.example.org 10.0.0.3
 | |
|     `
 | |
| 
 | |
| 	c := caddy.NewTestController("dns", input)
 | |
| 	setup(c)
 | |
| 	dnsserver.NewServer("", []*dnsserver.Config{dnsserver.GetConfig(c)})
 | |
| 
 | |
| 	handlers := dnsserver.GetConfig(c).Handlers()
 | |
| 	f1, ok := handlers[0].(*Forward)
 | |
| 	if !ok {
 | |
| 		t.Fatalf("expected first plugin to be Forward, got %v", reflect.TypeOf(f1.Next))
 | |
| 	}
 | |
| 
 | |
| 	if f1.from != "1st.example.org." {
 | |
| 		t.Errorf("expected first forward from \"1st.example.org.\", got %q", f1.from)
 | |
| 	}
 | |
| 	if f1.Next == nil {
 | |
| 		t.Fatal("expected first forward to point to next forward instance, not nil")
 | |
| 	}
 | |
| 
 | |
| 	f2, ok := f1.Next.(*Forward)
 | |
| 	if !ok {
 | |
| 		t.Fatalf("expected second plugin to be Forward, got %v", reflect.TypeOf(f1.Next))
 | |
| 	}
 | |
| 	if f2.from != "2nd.example.org." {
 | |
| 		t.Errorf("expected second forward from \"2nd.example.org.\", got %q", f2.from)
 | |
| 	}
 | |
| 	if f2.Next == nil {
 | |
| 		t.Fatal("expected second forward to point to third forward instance, got nil")
 | |
| 	}
 | |
| 
 | |
| 	f3, ok := f2.Next.(*Forward)
 | |
| 	if !ok {
 | |
| 		t.Fatalf("expected third plugin to be Forward, got %v", reflect.TypeOf(f2.Next))
 | |
| 	}
 | |
| 	if f3.from != "3rd.example.org." {
 | |
| 		t.Errorf("expected third forward from \"3rd.example.org.\", got %q", f3.from)
 | |
| 	}
 | |
| 	if f3.Next != nil {
 | |
| 		t.Error("expected third plugin to be last, but Next is not nil")
 | |
| 	}
 | |
| }
 |