mirror of
				https://github.com/coredns/coredns.git
				synced 2025-11-04 03:03:14 -05:00 
			
		
		
		
	Remove panic/recover and also use pkg/log to print the error. This brings some consistency into the logging. Fixes #1776
		
			
				
	
	
		
			34 lines
		
	
	
		
			718 B
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			34 lines
		
	
	
		
			718 B
		
	
	
	
		
			Go
		
	
	
	
	
	
package errors
 | 
						|
 | 
						|
import (
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"github.com/mholt/caddy"
 | 
						|
)
 | 
						|
 | 
						|
func TestErrorsParse(t *testing.T) {
 | 
						|
	tests := []struct {
 | 
						|
		inputErrorsRules string
 | 
						|
		shouldErr        bool
 | 
						|
	}{
 | 
						|
		{`errors`, false},
 | 
						|
		{`errors stdout`, false},
 | 
						|
		{`errors errors.txt`, true},
 | 
						|
		{`errors visible`, true},
 | 
						|
		{`errors { log visible }`, true},
 | 
						|
		{`errors
 | 
						|
		errors `, true},
 | 
						|
		{`errors a b`, true},
 | 
						|
	}
 | 
						|
	for i, test := range tests {
 | 
						|
		c := caddy.NewTestController("dns", test.inputErrorsRules)
 | 
						|
		_, err := errorsParse(c)
 | 
						|
 | 
						|
		if err == nil && test.shouldErr {
 | 
						|
			t.Errorf("Test %d didn't error, but it should have", i)
 | 
						|
		} else if err != nil && !test.shouldErr {
 | 
						|
			t.Errorf("Test %d errored, but it shouldn't have; got '%v'", i, err)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 |