Files
coredns/test/secondary_test.go
liucongran 2daf48e42d feat(secondary): Send NOTIFY messages after zone transfer (#7901)
* feat(secondary): Send NOTIFY messages after zone transfer

- Modified TransferIn() method to accept a transfer.Transfer parameter
- Added NOTIFY message sending after successful zone transfer in secondary plugin
- Updated Update() method to pass the transfer handler through the zone update cycle
- Added comprehensive tests for the secondary notify functionality

Closes #5669

Signed-off-by: liucongran <liucongran327@gmail.com>

* fix(secondary): Fix TransferIn method call in test

Update test to pass nil parameter to TransferIn method after signature change

Signed-off-by: liucongran <liucongran327@gmail.com>

* refactor(secondary): Clean up imports and add helper methods

- Reorder imports for consistency
- Add hasSOA() and getSOA() helper methods to Zone
- Remove unnecessary blank lines in tests

Signed-off-by: liucongran <liucongran327@gmail.com>

* fix(test): Fix variable declaration in secondary test

Change corefile variable assignment to use short declaration syntax (:=)
to fix compilation error.

Signed-off-by: liucongran <liucongran327@gmail.com>

* refactor(secondary): Use getSOA helper method in shouldTransfer

Replace direct SOA access with getSOA() helper method for consistency.

Signed-off-by: liucongran <liucongran327@gmail.com>

---------

Signed-off-by: liucongran <liucongran327@gmail.com>
Co-authored-by: liucongran <liucongran@cestc.cn>
2026-03-07 21:15:44 -08:00

332 lines
7.3 KiB
Go

package test
import (
"os"
"testing"
"time"
"github.com/coredns/coredns/plugin/test"
"github.com/miekg/dns"
)
func TestEmptySecondaryZone(t *testing.T) {
// Corefile that fails to transfer example.org.
corefile := `example.org:0 {
secondary {
transfer from 127.0.0.1:1717
}
}`
i, udp, _, err := CoreDNSServerAndPorts(corefile)
if err != nil {
t.Fatalf("Could not get CoreDNS serving instance: %s", err)
}
defer i.Stop()
m := new(dns.Msg)
m.SetQuestion("www.example.org.", dns.TypeA)
resp, err := dns.Exchange(m, udp)
if err != nil {
t.Fatal("Expected to receive reply, but didn't")
}
if resp.Rcode != dns.RcodeServerFailure {
t.Fatalf("Expected reply to be a SERVFAIL, got %d", resp.Rcode)
}
}
func TestSecondaryZoneTransfer(t *testing.T) {
name, rm, err := test.TempFile(".", exampleOrg)
if err != nil {
t.Fatalf("Failed to create zone: %s", err)
}
defer rm()
corefile := `example.org:0 {
file ` + name + ` {
}
transfer {
to *
}
}`
i, _, tcp, err := CoreDNSServerAndPorts(corefile)
if err != nil {
t.Fatalf("Could not get CoreDNS serving instance: %s", err)
}
defer i.Stop()
corefile = `example.org:0 {
secondary {
transfer from ` + tcp + `
}
}`
i1, udp, _, err := CoreDNSServerAndPorts(corefile)
if err != nil {
t.Fatalf("Could not get CoreDNS serving instance: %s", err)
}
defer i1.Stop()
m := new(dns.Msg)
m.SetQuestion("example.org.", dns.TypeSOA)
var r *dns.Msg
// This is now async; we need to wait for it to be transferred.
for range 10 {
r, _ = dns.Exchange(m, udp)
if len(r.Answer) != 0 {
break
}
time.Sleep(100 * time.Microsecond)
}
if len(r.Answer) == 0 {
t.Fatalf("Expected answer section")
}
}
func TestIxfrResponse(t *testing.T) {
// ixfr query with current soa should return single packet with that soa (no transfer needed).
name, rm, err := test.TempFile(".", exampleOrg)
if err != nil {
t.Fatalf("Failed to create zone: %s", err)
}
defer rm()
corefile := `example.org:0 {
file ` + name + ` {
}
transfer {
to *
}
}`
i, _, tcp, err := CoreDNSServerAndPorts(corefile)
if err != nil {
t.Fatalf("Could not get CoreDNS serving instance: %s", err)
}
defer i.Stop()
m := new(dns.Msg)
m.SetQuestion("example.org.", dns.TypeIXFR)
m.Ns = []dns.RR{test.SOA("example.org. IN SOA sns.dns.icann.org. noc.dns.icann.org. 2015082541 7200 3600 1209600 3600")} // copied from exampleOrg
var r *dns.Msg
c := new(dns.Client)
c.Net = "tcp"
// This is now async; we need to wait for it to be transferred.
for range 10 {
r, _, _ = c.Exchange(m, tcp)
if len(r.Answer) != 0 {
break
}
time.Sleep(100 * time.Microsecond)
}
if len(r.Answer) != 1 {
t.Fatalf("Expected answer section with single RR")
}
soa, ok := r.Answer[0].(*dns.SOA)
if !ok {
t.Fatalf("Expected answer section with SOA RR")
}
if soa.Serial != 2015082541 {
t.Fatalf("Serial should be %d, got %d", 2015082541, soa.Serial)
}
}
func TestRetryInitialTransfer(t *testing.T) {
// Start up a secondary that expects to transfer from a master that doesn't exist yet
corefile := `example.org:0 {
secondary {
transfer from 127.0.0.1:5399
}
}`
i, udp, _, err := CoreDNSServerAndPorts(corefile)
if err != nil {
t.Fatalf("Could not get CoreDNS serving instance: %s", err)
}
defer i.Stop()
m := new(dns.Msg)
m.SetQuestion("www.example.org.", dns.TypeA)
resp, err := dns.Exchange(m, udp)
if err != nil {
t.Fatal("Expected to receive reply, but didn't")
}
// Expect that the query will fail
if resp.Rcode != dns.RcodeServerFailure {
t.Fatalf("Expected reply to be a SERVFAIL, got %d", resp.Rcode)
}
// Now spin up the master server
name, rm, err := test.TempFile(".", `$ORIGIN example.org.
@ 3600 IN SOA sns.dns.icann.org. noc.dns.icann.org. (
2017042745 ; serial
7200 ; refresh (2 hours)
3600 ; retry (1 hour)
1209600 ; expire (2 weeks)
3600 ; minimum (1 hour)
)
3600 IN NS a.iana-servers.net.
3600 IN NS b.iana-servers.net.
www IN A 127.0.0.1
www IN AAAA ::1
`)
if err != nil {
t.Fatalf("Failed to create zone: %s", err)
}
defer rm()
corefileMaster := `example.org:5399 {
file ` + name + `
transfer {
to *
}
}`
master, _, _, err := CoreDNSServerAndPorts(corefileMaster)
if err != nil {
t.Fatalf("Could not start CoreDNS master: %s", err)
}
defer master.Stop()
retry := time.Tick(time.Millisecond * 100)
timeout := time.Tick(time.Second * 5)
for {
select {
case <-retry:
m = new(dns.Msg)
m.SetQuestion("www.example.org.", dns.TypeA)
resp, err = dns.Exchange(m, udp)
if err != nil {
continue
}
// Expect the query to succeed
if resp.Rcode != dns.RcodeSuccess {
continue
}
return
case <-timeout:
t.Fatal("Timed out trying for successful response.")
return
}
}
}
func TestSecondaryZoneNotify(t *testing.T) {
// Now spin up the master server
name, rm, err := test.TempFile(".", `$ORIGIN example.org.
@ 3600 IN SOA sns.dns.icann.org. noc.dns.icann.org. (
2017042745 ; serial
7200 ; refresh (2 hours)
3600 ; retry (1 hour)
1209600 ; expire (2 weeks)
3600 ; minimum (1 hour)
)
3600 IN NS a.iana-servers.net.
3600 IN NS b.iana-servers.net.
`)
if err != nil {
t.Fatalf("Failed to create zone: %s", err)
}
defer rm()
corefileMaster := `example.org:53553 {
bind 127.0.0.1
file ` + name + ` {
reload 0.01s
}
transfer {
to 127.0.0.1:53554
}
}`
master, _, _, err := CoreDNSServerAndPorts(corefileMaster)
if err != nil {
t.Fatalf("Could not get CoreDNS serving instance: %s", err)
}
defer master.Stop()
corefileSecondary := `example.org:53554 {
bind 127.0.0.1
secondary {
transfer from 127.0.0.1:53553
}
transfer {
to 127.0.0.1:53555
}
}`
secondary, _, _, err := CoreDNSServerAndPorts(corefileSecondary)
if err != nil {
t.Fatalf("Could not get CoreDNS serving instance: %s", err)
}
defer secondary.Stop()
corefile := `example.org:53555 {
bind 127.0.0.1
secondary {
transfer from 127.0.0.1:53554
}
}`
svr, udp, _, err := CoreDNSServerAndPorts(corefile)
if err != nil {
t.Fatalf("Could not get CoreDNS serving instance: %s", err)
}
defer svr.Stop()
m := new(dns.Msg)
m.SetQuestion("example.org.", dns.TypeSOA)
var r *dns.Msg
// This is now async; we need to wait for it to be transferred.
for range 10 {
r, _ = dns.Exchange(m, udp)
if len(r.Answer) != 0 {
break
}
time.Sleep(1000 * time.Microsecond)
}
if len(r.Answer) == 0 {
t.Fatalf("Expected answer section")
}
m = new(dns.Msg)
m.SetQuestion("www.example.org.", dns.TypeA)
r, _ = dns.Exchange(m, udp)
if len(r.Answer) != 0 {
t.Fatalf("Expected no answer section, got %d answers", len(r.Answer))
}
os.WriteFile(name, []byte(`$ORIGIN example.org.
@ 3600 IN SOA sns.dns.icann.org. noc.dns.icann.org. (
2017042746 ; serial
7200 ; refresh (2 hours)
3600 ; retry (1 hour)
1209600 ; expire (2 weeks)
3600 ; minimum (1 hour)
)
3600 IN NS a.iana-servers.net.
3600 IN NS b.iana-servers.net.
www IN A 127.0.0.1
`), 0644)
// This is now async; we need to wait for it to be transferred.
for range 10 {
r, _ = dns.Exchange(m, udp)
if len(r.Answer) != 0 {
break
}
time.Sleep(1000 * time.Microsecond)
}
if len(r.Answer) != 1 {
t.Fatalf("Expected one RR in answer section got %d", len(r.Answer))
}
}