mirror of
				https://github.com/coredns/coredns.git
				synced 2025-11-03 18:53:13 -05:00 
			
		
		
		
	* Speed up testing * make notification run in the background, this recudes the test_readme time from 18s to 0.10s * reduce time for zone reload * TestServeDNSConcurrent remove entirely. This took a whopping 58s for ... ? A few minutes staring didn't reveal wth it is actually testing. Making values smaller revealed race conditions in the tests. Remove entirely. * Move many interval values to variables so we can reset them to short values for the tests. * test_large_axfr: make the zone smaller. The number used 64K has no rational, make it 64/10 to speed up. * TestProxyThreeWay: use client with shorter timeout A few random tidbits in other tests. Total time saved: 177s (almost 3m) - which makes it worthwhile again to run the test locally: this branch: ~~~ ok github.com/coredns/coredns/test 10.437s cd plugin; time go t ./... 5,51s user 7,51s system 11,15s elapsed 744%CPU ( ~~~ master: ~~~ ok github.com/coredns/coredns/test 35.252s cd plugin; time go t ./... 157,64s user 15,39s system 50,05s elapsed 345%CPU () ~~~ tests/ -25s plugins/ -40s This brings the total on 20s, and another 10s can be saved by fixing dnstapio. Moving this to 5s would be even better, but 10s is also nice. Signed-off-by: Miek Gieben <miek@miek.nl> * Also 0.01 Signed-off-by: Miek Gieben <miek@miek.nl>
		
			
				
	
	
		
			68 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			68 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
package test
 | 
						|
 | 
						|
import (
 | 
						|
	"io/ioutil"
 | 
						|
	"testing"
 | 
						|
	"time"
 | 
						|
 | 
						|
	"github.com/coredns/coredns/plugin/test"
 | 
						|
 | 
						|
	"github.com/miekg/dns"
 | 
						|
)
 | 
						|
 | 
						|
func TestZoneReload(t *testing.T) {
 | 
						|
	name, rm, err := test.TempFile(".", exampleOrg)
 | 
						|
	if err != nil {
 | 
						|
		t.Fatalf("Failed to create zone: %s", err)
 | 
						|
	}
 | 
						|
	defer rm()
 | 
						|
 | 
						|
	// Corefile with two stanzas
 | 
						|
	corefile := `
 | 
						|
	example.org:0 {
 | 
						|
		file ` + name + ` {
 | 
						|
			reload 0.01s
 | 
						|
		}
 | 
						|
	}
 | 
						|
	example.net:0 {
 | 
						|
		file ` + name + `
 | 
						|
	}`
 | 
						|
 | 
						|
	i, udp, _, err := CoreDNSServerAndPorts(corefile)
 | 
						|
	if err != nil {
 | 
						|
		t.Fatalf("Could not get CoreDNS serving instance: %s", err)
 | 
						|
	}
 | 
						|
	defer i.Stop()
 | 
						|
 | 
						|
	m := new(dns.Msg)
 | 
						|
	m.SetQuestion("example.org.", dns.TypeA)
 | 
						|
	resp, err := dns.Exchange(m, udp)
 | 
						|
	if err != nil {
 | 
						|
		t.Fatalf("Expected to receive reply, but didn't: %s", err)
 | 
						|
	}
 | 
						|
	if len(resp.Answer) != 2 {
 | 
						|
		t.Fatalf("Expected two RR in answer section got %d", len(resp.Answer))
 | 
						|
	}
 | 
						|
 | 
						|
	// Remove RR from the Apex
 | 
						|
	ioutil.WriteFile(name, []byte(exampleOrgUpdated), 0644)
 | 
						|
 | 
						|
	time.Sleep(10 * time.Millisecond) // reload time
 | 
						|
 | 
						|
	resp, err = dns.Exchange(m, udp)
 | 
						|
	if err != nil {
 | 
						|
		t.Fatal("Expected to receive reply, but didn't")
 | 
						|
	}
 | 
						|
 | 
						|
	if len(resp.Answer) != 1 {
 | 
						|
		t.Fatalf("Expected two RR in answer section got %d", len(resp.Answer))
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
const exampleOrgUpdated = `; example.org test file
 | 
						|
example.org.		IN	SOA	sns.dns.icann.org. noc.dns.icann.org. 2016082541 7200 3600 1209600 3600
 | 
						|
example.org.		IN	NS	b.iana-servers.net.
 | 
						|
example.org.		IN	NS	a.iana-servers.net.
 | 
						|
example.org.		IN	A	127.0.0.2
 | 
						|
`
 |