mirror of
				https://github.com/coredns/coredns.git
				synced 2025-11-04 03:03:14 -05:00 
			
		
		
		
	* Make the RD-flag in health-checks in the Forward-plugin configurable Introduces a new configuration flag; `health_check_non_recursive`. This flag makes the health-checker do non-recursive requests when checking the health of upstream servers. Signed-off-by: Geir Haugom <ghagit@haugom.org> Signed-off-by: Christian Tryti <ctryti@gmail.com> * Changes after feedback from reviewer * Better tests of health-checks with and without recursion * Removed the health_check_non_recursive configuration in favor of extending the existing health_check configuration. Now supports an optional `no_rec` argument. Signed-off-by: Christian Tryti <ctryti@gmail.com> * Add new test that checks setup of health_check. Signed-off-by: Christian Tryti <ctryti@gmail.com>
		
			
				
	
	
		
			226 lines
		
	
	
		
			5.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			226 lines
		
	
	
		
			5.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
package forward
 | 
						|
 | 
						|
import (
 | 
						|
	"context"
 | 
						|
	"sync/atomic"
 | 
						|
	"testing"
 | 
						|
	"time"
 | 
						|
 | 
						|
	"github.com/coredns/coredns/plugin/pkg/dnstest"
 | 
						|
	"github.com/coredns/coredns/plugin/pkg/transport"
 | 
						|
	"github.com/coredns/coredns/plugin/test"
 | 
						|
 | 
						|
	"github.com/miekg/dns"
 | 
						|
)
 | 
						|
 | 
						|
func TestHealth(t *testing.T) {
 | 
						|
	const expected = 1
 | 
						|
	i := uint32(0)
 | 
						|
	q := uint32(0)
 | 
						|
	s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
 | 
						|
		if atomic.LoadUint32(&q) == 0 { //drop the first query to trigger health-checking
 | 
						|
			atomic.AddUint32(&q, 1)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		if r.Question[0].Name == "." && r.RecursionDesired == true {
 | 
						|
			atomic.AddUint32(&i, 1)
 | 
						|
		}
 | 
						|
		ret := new(dns.Msg)
 | 
						|
		ret.SetReply(r)
 | 
						|
		w.WriteMsg(ret)
 | 
						|
	})
 | 
						|
	defer s.Close()
 | 
						|
 | 
						|
	p := NewProxy(s.Addr, transport.DNS)
 | 
						|
	f := New()
 | 
						|
	f.SetProxy(p)
 | 
						|
	defer f.OnShutdown()
 | 
						|
 | 
						|
	req := new(dns.Msg)
 | 
						|
	req.SetQuestion("example.org.", dns.TypeA)
 | 
						|
 | 
						|
	f.ServeDNS(context.TODO(), &test.ResponseWriter{}, req)
 | 
						|
 | 
						|
	time.Sleep(1 * time.Second)
 | 
						|
	i1 := atomic.LoadUint32(&i)
 | 
						|
	if i1 != expected {
 | 
						|
		t.Errorf("Expected number of health checks with RecursionDesired==true to be %d, got %d", expected, i1)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestHealthNoRecursion(t *testing.T) {
 | 
						|
	const expected = 1
 | 
						|
	i := uint32(0)
 | 
						|
	q := uint32(0)
 | 
						|
	s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
 | 
						|
		if atomic.LoadUint32(&q) == 0 { //drop the first query to trigger health-checking
 | 
						|
			atomic.AddUint32(&q, 1)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		if r.Question[0].Name == "." && r.RecursionDesired == false {
 | 
						|
			atomic.AddUint32(&i, 1)
 | 
						|
		}
 | 
						|
		ret := new(dns.Msg)
 | 
						|
		ret.SetReply(r)
 | 
						|
		w.WriteMsg(ret)
 | 
						|
	})
 | 
						|
	defer s.Close()
 | 
						|
 | 
						|
	p := NewProxy(s.Addr, transport.DNS)
 | 
						|
	p.health.SetRecursionDesired(false)
 | 
						|
	f := New()
 | 
						|
	f.SetProxy(p)
 | 
						|
	defer f.OnShutdown()
 | 
						|
 | 
						|
	req := new(dns.Msg)
 | 
						|
	req.SetQuestion("example.org.", dns.TypeA)
 | 
						|
 | 
						|
	f.ServeDNS(context.TODO(), &test.ResponseWriter{}, req)
 | 
						|
 | 
						|
	time.Sleep(1 * time.Second)
 | 
						|
	i1 := atomic.LoadUint32(&i)
 | 
						|
	if i1 != expected {
 | 
						|
		t.Errorf("Expected number of health checks with RecursionDesired==false to be %d, got %d", expected, i1)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestHealthTimeout(t *testing.T) {
 | 
						|
	const expected = 1
 | 
						|
	i := uint32(0)
 | 
						|
	q := uint32(0)
 | 
						|
	s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
 | 
						|
		if r.Question[0].Name == "." {
 | 
						|
			// health check, answer
 | 
						|
			atomic.AddUint32(&i, 1)
 | 
						|
			ret := new(dns.Msg)
 | 
						|
			ret.SetReply(r)
 | 
						|
			w.WriteMsg(ret)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		if atomic.LoadUint32(&q) == 0 { //drop only first query
 | 
						|
			atomic.AddUint32(&q, 1)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		ret := new(dns.Msg)
 | 
						|
		ret.SetReply(r)
 | 
						|
		w.WriteMsg(ret)
 | 
						|
	})
 | 
						|
	defer s.Close()
 | 
						|
 | 
						|
	p := NewProxy(s.Addr, transport.DNS)
 | 
						|
	f := New()
 | 
						|
	f.SetProxy(p)
 | 
						|
	defer f.OnShutdown()
 | 
						|
 | 
						|
	req := new(dns.Msg)
 | 
						|
	req.SetQuestion("example.org.", dns.TypeA)
 | 
						|
 | 
						|
	f.ServeDNS(context.TODO(), &test.ResponseWriter{}, req)
 | 
						|
 | 
						|
	time.Sleep(1 * time.Second)
 | 
						|
	i1 := atomic.LoadUint32(&i)
 | 
						|
	if i1 != expected {
 | 
						|
		t.Errorf("Expected number of health checks to be %d, got %d", expected, i1)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestHealthFailTwice(t *testing.T) {
 | 
						|
	const expected = 2
 | 
						|
	i := uint32(0)
 | 
						|
	q := uint32(0)
 | 
						|
	s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
 | 
						|
		if r.Question[0].Name == "." {
 | 
						|
			atomic.AddUint32(&i, 1)
 | 
						|
			i1 := atomic.LoadUint32(&i)
 | 
						|
			// Timeout health until we get the second one
 | 
						|
			if i1 < 2 {
 | 
						|
				return
 | 
						|
			}
 | 
						|
			ret := new(dns.Msg)
 | 
						|
			ret.SetReply(r)
 | 
						|
			w.WriteMsg(ret)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		if atomic.LoadUint32(&q) == 0 { //drop only first query
 | 
						|
			atomic.AddUint32(&q, 1)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		ret := new(dns.Msg)
 | 
						|
		ret.SetReply(r)
 | 
						|
		w.WriteMsg(ret)
 | 
						|
	})
 | 
						|
	defer s.Close()
 | 
						|
 | 
						|
	p := NewProxy(s.Addr, transport.DNS)
 | 
						|
	f := New()
 | 
						|
	f.SetProxy(p)
 | 
						|
	defer f.OnShutdown()
 | 
						|
 | 
						|
	req := new(dns.Msg)
 | 
						|
	req.SetQuestion("example.org.", dns.TypeA)
 | 
						|
 | 
						|
	f.ServeDNS(context.TODO(), &test.ResponseWriter{}, req)
 | 
						|
 | 
						|
	time.Sleep(3 * time.Second)
 | 
						|
	i1 := atomic.LoadUint32(&i)
 | 
						|
	if i1 != expected {
 | 
						|
		t.Errorf("Expected number of health checks to be %d, got %d", expected, i1)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestHealthMaxFails(t *testing.T) {
 | 
						|
	s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
 | 
						|
		// timeout
 | 
						|
	})
 | 
						|
	defer s.Close()
 | 
						|
 | 
						|
	p := NewProxy(s.Addr, transport.DNS)
 | 
						|
	f := New()
 | 
						|
	f.maxfails = 2
 | 
						|
	f.SetProxy(p)
 | 
						|
	defer f.OnShutdown()
 | 
						|
 | 
						|
	req := new(dns.Msg)
 | 
						|
	req.SetQuestion("example.org.", dns.TypeA)
 | 
						|
 | 
						|
	f.ServeDNS(context.TODO(), &test.ResponseWriter{}, req)
 | 
						|
 | 
						|
	time.Sleep(readTimeout + 1*time.Second)
 | 
						|
	fails := atomic.LoadUint32(&p.fails)
 | 
						|
	if !p.Down(f.maxfails) {
 | 
						|
		t.Errorf("Expected Proxy fails to be greater than %d, got %d", f.maxfails, fails)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestHealthNoMaxFails(t *testing.T) {
 | 
						|
	const expected = 0
 | 
						|
	i := uint32(0)
 | 
						|
	s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
 | 
						|
		if r.Question[0].Name == "." {
 | 
						|
			// health check, answer
 | 
						|
			atomic.AddUint32(&i, 1)
 | 
						|
			ret := new(dns.Msg)
 | 
						|
			ret.SetReply(r)
 | 
						|
			w.WriteMsg(ret)
 | 
						|
		}
 | 
						|
	})
 | 
						|
	defer s.Close()
 | 
						|
 | 
						|
	p := NewProxy(s.Addr, transport.DNS)
 | 
						|
	f := New()
 | 
						|
	f.maxfails = 0
 | 
						|
	f.SetProxy(p)
 | 
						|
	defer f.OnShutdown()
 | 
						|
 | 
						|
	req := new(dns.Msg)
 | 
						|
	req.SetQuestion("example.org.", dns.TypeA)
 | 
						|
 | 
						|
	f.ServeDNS(context.TODO(), &test.ResponseWriter{}, req)
 | 
						|
 | 
						|
	time.Sleep(1 * time.Second)
 | 
						|
	i1 := atomic.LoadUint32(&i)
 | 
						|
	if i1 != expected {
 | 
						|
		t.Errorf("Expected number of health checks to be %d, got %d", expected, i1)
 | 
						|
	}
 | 
						|
}
 |