mirror of
https://github.com/coredns/coredns.git
synced 2025-11-01 10:43:17 -04:00
84dfdab584
Cache the size and the do bit whenever someone asked for it. We can probably add more: PASS BenchmarkStateDo-4 100000000 11.9 ns/op BenchmarkStateSize-4 5000000 265 ns/op ok github.com/miekg/coredns/middleware 2.828s PASS BenchmarkStateDo-4 1000000000 2.86 ns/op BenchmarkStateSize-4 500000000 3.10 ns/op ok github.com/miekg/coredns/middleware 5.032s This PR also includes some testing cleanups as well.
52 lines
1.0 KiB
Go
52 lines
1.0 KiB
Go
package log
|
|
|
|
import (
|
|
"bytes"
|
|
"log"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/miekg/coredns/middleware"
|
|
coretest "github.com/miekg/coredns/middleware/testing"
|
|
|
|
"github.com/miekg/dns"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
type erroringMiddleware struct{}
|
|
|
|
func (erroringMiddleware) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
|
|
return dns.RcodeServerFailure, nil
|
|
}
|
|
|
|
func TestLoggedStatus(t *testing.T) {
|
|
var f bytes.Buffer
|
|
var next erroringMiddleware
|
|
rule := Rule{
|
|
NameScope: ".",
|
|
Format: DefaultLogFormat,
|
|
Log: log.New(&f, "", 0),
|
|
}
|
|
|
|
logger := Logger{
|
|
Rules: []Rule{rule},
|
|
Next: next,
|
|
}
|
|
|
|
ctx := context.TODO()
|
|
r := new(dns.Msg)
|
|
r.SetQuestion("example.org.", dns.TypeA)
|
|
|
|
rec := middleware.NewResponseRecorder(&coretest.ResponseWriter{})
|
|
|
|
rcode, _ := logger.ServeDNS(ctx, rec, r)
|
|
if rcode != 0 {
|
|
t.Error("Expected rcode to be 0 - was", rcode)
|
|
}
|
|
|
|
logged := f.String()
|
|
if !strings.Contains(logged, "A example.org. udp") {
|
|
t.Error("Expected it to be logged. Logged string -", logged)
|
|
}
|
|
}
|