mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-31 02:03:20 -04:00 
			
		
		
		
	* plugin/forward: on demand healtchecking Only start doing health checks when we encouner an error (any error). This uses the new pluing/pkg/up package to abstract away the actual checking. This reduces the LOC quite a bit; does need more testing, unit testing and tcpdumping a bit. * fix tests * Fix readme * Use pkg/up for healthchecks * remove unused channel * more cleanups * update readme * * Again do go generate and go build; still referencing the wrong forward repo? Anyway fixed. * Use pkg/up for doing the healtchecks to cut back on unwanted queries * Change up.Func to return an error instead of a boolean. * Drop the string target argument as it doesn't make sense. * Add healthcheck test on failing to get an upstream answer. TODO(miek): double check Forward and Lookup and how they interact with HC, and if we correctly call close() on those * actual test * Tests here * more tests * try getting rid of host * Get rid of the host indirection * Finish removing hosts * moar testing * import fmt * field is not used * docs * move some stuff * bring back health_check * maxfails=0 test * git and merging, bah * review
		
			
				
	
	
		
			168 lines
		
	
	
		
			4.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			168 lines
		
	
	
		
			4.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package forward
 | |
| 
 | |
| import (
 | |
| 	"crypto/tls"
 | |
| 	"net"
 | |
| 	"time"
 | |
| 
 | |
| 	"github.com/miekg/dns"
 | |
| )
 | |
| 
 | |
| // a persistConn hold the dns.Conn and the last used time.
 | |
| type persistConn struct {
 | |
| 	c    *dns.Conn
 | |
| 	used time.Time
 | |
| }
 | |
| 
 | |
| // connErr is used to communicate the connection manager.
 | |
| type connErr struct {
 | |
| 	c   *dns.Conn
 | |
| 	err error
 | |
| }
 | |
| 
 | |
| // transport hold the persistent cache.
 | |
| type transport struct {
 | |
| 	conns     map[string][]*persistConn //  Buckets for udp, tcp and tcp-tls.
 | |
| 	expire    time.Duration             // After this duration a connection is expired.
 | |
| 	addr      string
 | |
| 	tlsConfig *tls.Config
 | |
| 
 | |
| 	dial  chan string
 | |
| 	yield chan connErr
 | |
| 	ret   chan connErr
 | |
| 
 | |
| 	// Aid in testing, gets length of cache in data-race safe manner.
 | |
| 	lenc    chan bool
 | |
| 	lencOut chan int
 | |
| 
 | |
| 	stop chan bool
 | |
| }
 | |
| 
 | |
| func newTransport(addr string, tlsConfig *tls.Config) *transport {
 | |
| 	t := &transport{
 | |
| 		conns:   make(map[string][]*persistConn),
 | |
| 		expire:  defaultExpire,
 | |
| 		addr:    addr,
 | |
| 		dial:    make(chan string),
 | |
| 		yield:   make(chan connErr),
 | |
| 		ret:     make(chan connErr),
 | |
| 		stop:    make(chan bool),
 | |
| 		lenc:    make(chan bool),
 | |
| 		lencOut: make(chan int),
 | |
| 	}
 | |
| 	go t.connManager()
 | |
| 	return t
 | |
| }
 | |
| 
 | |
| // len returns the number of connection, used for metrics. Can only be safely
 | |
| // used inside connManager() because of data races.
 | |
| func (t *transport) len() int {
 | |
| 	l := 0
 | |
| 	for _, conns := range t.conns {
 | |
| 		l += len(conns)
 | |
| 	}
 | |
| 	return l
 | |
| }
 | |
| 
 | |
| // Len returns the number of connections in the cache.
 | |
| func (t *transport) Len() int {
 | |
| 	t.lenc <- true
 | |
| 	l := <-t.lencOut
 | |
| 	return l
 | |
| }
 | |
| 
 | |
| // connManagers manages the persistent connection cache for UDP and TCP.
 | |
| func (t *transport) connManager() {
 | |
| 
 | |
| Wait:
 | |
| 	for {
 | |
| 		select {
 | |
| 		case proto := <-t.dial:
 | |
| 			// Yes O(n), shouldn't put millions in here. We walk all connection until we find the first
 | |
| 			// one that is usuable.
 | |
| 			i := 0
 | |
| 			for i = 0; i < len(t.conns[proto]); i++ {
 | |
| 				pc := t.conns[proto][i]
 | |
| 				if time.Since(pc.used) < t.expire {
 | |
| 					// Found one, remove from pool and return this conn.
 | |
| 					t.conns[proto] = t.conns[proto][i+1:]
 | |
| 					t.ret <- connErr{pc.c, nil}
 | |
| 					continue Wait
 | |
| 				}
 | |
| 				// This conn has expired. Close it.
 | |
| 				pc.c.Close()
 | |
| 			}
 | |
| 
 | |
| 			// Not conns were found. Connect to the upstream to create one.
 | |
| 			t.conns[proto] = t.conns[proto][i:]
 | |
| 			SocketGauge.WithLabelValues(t.addr).Set(float64(t.len()))
 | |
| 
 | |
| 			go func() {
 | |
| 				if proto != "tcp-tls" {
 | |
| 					c, err := dns.DialTimeout(proto, t.addr, dialTimeout)
 | |
| 					t.ret <- connErr{c, err}
 | |
| 					return
 | |
| 				}
 | |
| 
 | |
| 				c, err := dns.DialTimeoutWithTLS("tcp", t.addr, t.tlsConfig, dialTimeout)
 | |
| 				t.ret <- connErr{c, err}
 | |
| 			}()
 | |
| 
 | |
| 		case conn := <-t.yield:
 | |
| 
 | |
| 			SocketGauge.WithLabelValues(t.addr).Set(float64(t.len() + 1))
 | |
| 
 | |
| 			// no proto here, infer from config and conn
 | |
| 			if _, ok := conn.c.Conn.(*net.UDPConn); ok {
 | |
| 				t.conns["udp"] = append(t.conns["udp"], &persistConn{conn.c, time.Now()})
 | |
| 				continue Wait
 | |
| 			}
 | |
| 
 | |
| 			if t.tlsConfig == nil {
 | |
| 				t.conns["tcp"] = append(t.conns["tcp"], &persistConn{conn.c, time.Now()})
 | |
| 				continue Wait
 | |
| 			}
 | |
| 
 | |
| 			t.conns["tcp-tls"] = append(t.conns["tcp-tls"], &persistConn{conn.c, time.Now()})
 | |
| 
 | |
| 		case <-t.stop:
 | |
| 			return
 | |
| 
 | |
| 		case <-t.lenc:
 | |
| 			l := 0
 | |
| 			for _, conns := range t.conns {
 | |
| 				l += len(conns)
 | |
| 			}
 | |
| 			t.lencOut <- l
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| // Dial dials the address configured in transport, potentially reusing a connection or creating a new one.
 | |
| func (t *transport) Dial(proto string) (*dns.Conn, error) {
 | |
| 	// If tls has been configured; use it.
 | |
| 	if t.tlsConfig != nil {
 | |
| 		proto = "tcp-tls"
 | |
| 	}
 | |
| 
 | |
| 	t.dial <- proto
 | |
| 	c := <-t.ret
 | |
| 	return c.c, c.err
 | |
| }
 | |
| 
 | |
| // Yield return the connection to transport for reuse.
 | |
| func (t *transport) Yield(c *dns.Conn) {
 | |
| 	t.yield <- connErr{c, nil}
 | |
| }
 | |
| 
 | |
| // Stop stops the transport's connection manager.
 | |
| func (t *transport) Stop() { t.stop <- true }
 | |
| 
 | |
| // SetExpire sets the connection expire time in transport.
 | |
| func (t *transport) SetExpire(expire time.Duration) { t.expire = expire }
 | |
| 
 | |
| // SetTLSConfig sets the TLS config in transport.
 | |
| func (t *transport) SetTLSConfig(cfg *tls.Config) { t.tlsConfig = cfg }
 | |
| 
 | |
| const defaultExpire = 10 * time.Second
 |