mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-31 02:03:20 -04:00 
			
		
		
		
	Abstract the caddy call and make it simpler. See #3261 for some part of the discussion. Go from: ~~~ go func init() { caddy.RegisterPlugin("any", caddy.Plugin{ ServerType: "dns", Action: setup, }) } ~~~ To: ~~~ go func init() { plugin.Register("any", setup) } ~~~ This requires some external documents in coredns.io to be updated as well; the old way still works, so it's backwards compatible. Signed-off-by: Miek Gieben <miek@miek.nl>
		
			
				
	
	
		
			74 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			74 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package health
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"net"
 | |
| 	"time"
 | |
| 
 | |
| 	"github.com/coredns/coredns/plugin"
 | |
| 	"github.com/coredns/coredns/plugin/metrics"
 | |
| 
 | |
| 	"github.com/caddyserver/caddy"
 | |
| )
 | |
| 
 | |
| func init() { plugin.Register("health", setup) }
 | |
| 
 | |
| func setup(c *caddy.Controller) error {
 | |
| 	addr, lame, err := parse(c)
 | |
| 	if err != nil {
 | |
| 		return plugin.Error("health", err)
 | |
| 	}
 | |
| 
 | |
| 	h := &health{Addr: addr, stop: make(chan bool), lameduck: lame}
 | |
| 
 | |
| 	c.OnStartup(func() error {
 | |
| 		metrics.MustRegister(c, HealthDuration)
 | |
| 		return nil
 | |
| 	})
 | |
| 
 | |
| 	c.OnStartup(h.OnStartup)
 | |
| 	c.OnRestart(h.OnFinalShutdown)
 | |
| 	c.OnFinalShutdown(h.OnFinalShutdown)
 | |
| 	c.OnRestartFailed(h.OnStartup)
 | |
| 
 | |
| 	// Don't do AddPlugin, as health is not *really* a plugin just a separate webserver running.
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| func parse(c *caddy.Controller) (string, time.Duration, error) {
 | |
| 	addr := ""
 | |
| 	dur := time.Duration(0)
 | |
| 	for c.Next() {
 | |
| 		args := c.RemainingArgs()
 | |
| 
 | |
| 		switch len(args) {
 | |
| 		case 0:
 | |
| 		case 1:
 | |
| 			addr = args[0]
 | |
| 			if _, _, e := net.SplitHostPort(addr); e != nil {
 | |
| 				return "", 0, e
 | |
| 			}
 | |
| 		default:
 | |
| 			return "", 0, c.ArgErr()
 | |
| 		}
 | |
| 
 | |
| 		for c.NextBlock() {
 | |
| 			switch c.Val() {
 | |
| 			case "lameduck":
 | |
| 				args := c.RemainingArgs()
 | |
| 				if len(args) != 1 {
 | |
| 					return "", 0, c.ArgErr()
 | |
| 				}
 | |
| 				l, err := time.ParseDuration(args[0])
 | |
| 				if err != nil {
 | |
| 					return "", 0, fmt.Errorf("unable to parse lameduck duration value: '%v' : %v", args[0], err)
 | |
| 				}
 | |
| 				dur = l
 | |
| 			default:
 | |
| 				return "", 0, c.ArgErr()
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| 	return addr, dur, nil
 | |
| }
 |