mirror of
				https://github.com/coredns/coredns.git
				synced 2025-11-04 03:03:14 -05:00 
			
		
		
		
	* Fix linter errors * More linting fixes * More docs and making members private that dont need to be public * Fix linter errors * More linting fixes * More docs and making members private that dont need to be public * More lint fixes This leaves: ~~~ middleware/kubernetes/nametemplate/nametemplate.go:64:6: exported type NameTemplate should have comment or be unexported middleware/kubernetes/nametemplate/nametemplate.go:71:1: exported method NameTemplate.SetTemplate should have comment or be unexported middleware/kubernetes/nametemplate/nametemplate.go:108:1: exported method NameTemplate.GetZoneFromSegmentArray should have comment or be unexported middleware/kubernetes/nametemplate/nametemplate.go:116:1: exported method NameTemplate.GetNamespaceFromSegmentArray should have comment or be unexported middleware/kubernetes/nametemplate/nametemplate.go:120:1: exported method NameTemplate.GetServiceFromSegmentArray should have comment or be unexported middleware/kubernetes/nametemplate/nametemplate.go:124:1: exported method NameTemplate.GetTypeFromSegmentArray should have comment or be unexported middleware/kubernetes/nametemplate/nametemplate.go:135:1: exported method NameTemplate.GetSymbolFromSegmentArray should have comment or be unexported middleware/kubernetes/nametemplate/nametemplate.go:167:1: exported method NameTemplate.IsValid should have comment or be unexported middleware/kubernetes/nametemplate/nametemplate.go:182:6: exported type NameValues should have comment or be unexported middleware/kubernetes/util/util.go:1:1: package comment should be of the form "Package util ..." middleware/kubernetes/util/util.go:27:2: exported const WildcardStar should have comment (or a comment on this block) or be unexported middleware/proxy/lookup.go:66:1: exported method Proxy.Forward should have comment or be unexported middleware/proxy/proxy.go:24:6: exported type Client should have comment or be unexported middleware/proxy/proxy.go:107:1: exported function Clients should have comment or be unexported middleware/proxy/reverseproxy.go:10:6: exported type ReverseProxy should have comment or be unexported middleware/proxy/reverseproxy.go:16:1: exported method ReverseProxy.ServeDNS should have comment or be unexported middleware/proxy/upstream.go:42:6: exported type Options should have comment or be unexported ~~~ I plan on reworking the proxy anyway, so I'll leave that be.
		
			
				
	
	
		
			49 lines
		
	
	
		
			1.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			49 lines
		
	
	
		
			1.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
package errors
 | 
						|
 | 
						|
import (
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"github.com/mholt/caddy"
 | 
						|
)
 | 
						|
 | 
						|
func TestErrorsParse(t *testing.T) {
 | 
						|
	tests := []struct {
 | 
						|
		inputErrorsRules     string
 | 
						|
		shouldErr            bool
 | 
						|
		expectedErrorHandler errorHandler
 | 
						|
	}{
 | 
						|
		{`errors`, false, errorHandler{
 | 
						|
			LogFile: "",
 | 
						|
		}},
 | 
						|
		{`errors errors.txt`, false, errorHandler{
 | 
						|
			LogFile: "errors.txt",
 | 
						|
		}},
 | 
						|
		{`errors visible`, false, errorHandler{
 | 
						|
			LogFile: "",
 | 
						|
			Debug:   true,
 | 
						|
		}},
 | 
						|
		{`errors { log visible }`, false, errorHandler{
 | 
						|
			LogFile: "",
 | 
						|
			Debug:   true,
 | 
						|
		}},
 | 
						|
	}
 | 
						|
	for i, test := range tests {
 | 
						|
		c := caddy.NewTestController("dns", test.inputErrorsRules)
 | 
						|
		actualErrorsRule, err := errorsParse(c)
 | 
						|
 | 
						|
		if err == nil && test.shouldErr {
 | 
						|
			t.Errorf("Test %d didn't error, but it should have", i)
 | 
						|
		} else if err != nil && !test.shouldErr {
 | 
						|
			t.Errorf("Test %d errored, but it shouldn't have; got '%v'", i, err)
 | 
						|
		}
 | 
						|
		if actualErrorsRule.LogFile != test.expectedErrorHandler.LogFile {
 | 
						|
			t.Errorf("Test %d expected LogFile to be %s, but got %s",
 | 
						|
				i, test.expectedErrorHandler.LogFile, actualErrorsRule.LogFile)
 | 
						|
		}
 | 
						|
		if actualErrorsRule.Debug != test.expectedErrorHandler.Debug {
 | 
						|
			t.Errorf("Test %d expected Debug to be %v, but got %v",
 | 
						|
				i, test.expectedErrorHandler.Debug, actualErrorsRule.Debug)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 |