mirror of
https://github.com/coredns/coredns.git
synced 2025-10-27 16:24:19 -04:00
Make the receiver a pointer so that the uptdateStubZones map update will retain the stubzones found, unlike the current case where the update will be applied and then promptly forgotten, because it is working on a copy. Add test/etcd_test.go to test a large part of the code. This didn't catch the chaos middleware hack though. The chaos middleware zones are now *not* automatically added. You have to take care of that by yourself (docs updates). When using debug queries and falling through to the next middleware in etcd, restore the original (with o-o.debug) query before passing it on.
160 lines
4.1 KiB
Go
160 lines
4.1 KiB
Go
// Package etcd provides the etcd backend.
|
|
package etcd
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/miekg/coredns/middleware"
|
|
"github.com/miekg/coredns/middleware/etcd/msg"
|
|
"github.com/miekg/coredns/middleware/proxy"
|
|
"github.com/miekg/coredns/middleware/singleflight"
|
|
|
|
etcdc "github.com/coreos/etcd/client"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
type Etcd struct {
|
|
Next middleware.Handler
|
|
Zones []string
|
|
PathPrefix string
|
|
Proxy proxy.Proxy // Proxy for looking up names during the resolution process
|
|
Client etcdc.KeysAPI
|
|
Ctx context.Context
|
|
Inflight *singleflight.Group
|
|
Stubmap *map[string]proxy.Proxy // List of proxies for stub resolving.
|
|
Debug bool // Do we allow debug queries.
|
|
}
|
|
|
|
// Records looks up records in etcd. If exact is true, it will lookup just
|
|
// this name. This is used when find matches when completing SRV lookups
|
|
// for instance.
|
|
func (e *Etcd) Records(name string, exact bool) ([]msg.Service, error) {
|
|
path, star := msg.PathWithWildcard(name, e.PathPrefix)
|
|
r, err := e.Get(path, true)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
segments := strings.Split(msg.Path(name, e.PathPrefix), "/")
|
|
switch {
|
|
case exact && r.Node.Dir:
|
|
return nil, nil
|
|
case r.Node.Dir:
|
|
return e.loopNodes(r.Node.Nodes, segments, star, nil)
|
|
default:
|
|
return e.loopNodes([]*etcdc.Node{r.Node}, segments, false, nil)
|
|
}
|
|
}
|
|
|
|
// Get is a wrapper for client.Get that uses SingleInflight to suppress multiple outstanding queries.
|
|
func (e *Etcd) Get(path string, recursive bool) (*etcdc.Response, error) {
|
|
resp, err := e.Inflight.Do(path, func() (interface{}, error) {
|
|
ctx, cancel := context.WithTimeout(e.Ctx, etcdTimeout)
|
|
defer cancel()
|
|
r, e := e.Client.Get(ctx, path, &etcdc.GetOptions{Sort: false, Recursive: recursive})
|
|
if e != nil {
|
|
return nil, e
|
|
}
|
|
return r, e
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return resp.(*etcdc.Response), err
|
|
}
|
|
|
|
// skydns/local/skydns/east/staging/web
|
|
// skydns/local/skydns/west/production/web
|
|
//
|
|
// skydns/local/skydns/*/*/web
|
|
// skydns/local/skydns/*/web
|
|
|
|
// loopNodes recursively loops through the nodes and returns all the values. The nodes' keyname
|
|
// will be match against any wildcards when star is true.
|
|
func (e Etcd) loopNodes(ns []*etcdc.Node, nameParts []string, star bool, bx map[msg.Service]bool) (sx []msg.Service, err error) {
|
|
if bx == nil {
|
|
bx = make(map[msg.Service]bool)
|
|
}
|
|
Nodes:
|
|
for _, n := range ns {
|
|
if n.Dir {
|
|
nodes, err := e.loopNodes(n.Nodes, nameParts, star, bx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
sx = append(sx, nodes...)
|
|
continue
|
|
}
|
|
if star {
|
|
keyParts := strings.Split(n.Key, "/")
|
|
for i, n := range nameParts {
|
|
if i > len(keyParts)-1 {
|
|
// name is longer than key
|
|
continue Nodes
|
|
}
|
|
if n == "*" || n == "any" {
|
|
continue
|
|
}
|
|
if keyParts[i] != n {
|
|
continue Nodes
|
|
}
|
|
}
|
|
}
|
|
serv := new(msg.Service)
|
|
if err := json.Unmarshal([]byte(n.Value), serv); err != nil {
|
|
return nil, fmt.Errorf("%s: %s", n.Key, err.Error())
|
|
}
|
|
b := msg.Service{Host: serv.Host, Port: serv.Port, Priority: serv.Priority, Weight: serv.Weight, Text: serv.Text, Key: n.Key}
|
|
if _, ok := bx[b]; ok {
|
|
continue
|
|
}
|
|
bx[b] = true
|
|
|
|
serv.Key = n.Key
|
|
serv.Ttl = e.TTL(n, serv)
|
|
if serv.Priority == 0 {
|
|
serv.Priority = priority
|
|
}
|
|
sx = append(sx, *serv)
|
|
}
|
|
return sx, nil
|
|
}
|
|
|
|
// TTL returns the smaller of the etcd TTL and the service's
|
|
// TTL. If neither of these are set (have a zero value), a default is used.
|
|
func (e *Etcd) TTL(node *etcdc.Node, serv *msg.Service) uint32 {
|
|
etcdTTL := uint32(node.TTL)
|
|
|
|
if etcdTTL == 0 && serv.Ttl == 0 {
|
|
return ttl
|
|
}
|
|
if etcdTTL == 0 {
|
|
return serv.Ttl
|
|
}
|
|
if serv.Ttl == 0 {
|
|
return etcdTTL
|
|
}
|
|
if etcdTTL < serv.Ttl {
|
|
return etcdTTL
|
|
}
|
|
return serv.Ttl
|
|
}
|
|
|
|
// etcNameError checks if the error is ErrorCodeKeyNotFound from etcd.
|
|
func isEtcdNameError(err error) bool {
|
|
if e, ok := err.(etcdc.Error); ok && e.Code == etcdc.ErrorCodeKeyNotFound {
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
const (
|
|
priority = 10 // default priority when nothing is set
|
|
ttl = 300 // default ttl when nothing is set
|
|
minTTL = 60
|
|
hostmaster = "hostmaster"
|
|
etcdTimeout = 5 * time.Second
|
|
)
|