mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-31 10:13:14 -04:00 
			
		
		
		
	Add more unit tests for metrics plugin, around registration deduplication, zone management, restart/shutdown behavior and context helpers. Increases test coverage from 54.8% to 76.1%. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
		
			
				
	
	
		
			50 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			50 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package metrics
 | |
| 
 | |
| import (
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/coredns/caddy"
 | |
| )
 | |
| 
 | |
| func TestPrometheusParse(t *testing.T) {
 | |
| 	tests := []struct {
 | |
| 		input     string
 | |
| 		shouldErr bool
 | |
| 		addr      string
 | |
| 	}{
 | |
| 		// oks
 | |
| 		{`prometheus`, false, "localhost:9153"},
 | |
| 		{`prometheus localhost:53`, false, "localhost:53"},
 | |
| 		// fails
 | |
| 		{`prometheus {}`, true, ""},
 | |
| 		{`prometheus /foo`, true, ""},
 | |
| 		{`prometheus a b c`, true, ""},
 | |
| 	}
 | |
| 	for i, test := range tests {
 | |
| 		c := caddy.NewTestController("dns", test.input)
 | |
| 		m, err := parse(c)
 | |
| 		if test.shouldErr && err == nil {
 | |
| 			t.Errorf("Test %v: Expected error but found nil", i)
 | |
| 			continue
 | |
| 		} else if !test.shouldErr && err != nil {
 | |
| 			t.Errorf("Test %v: Expected no error but found error: %v", i, err)
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		if test.shouldErr {
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		if test.addr != m.Addr {
 | |
| 			t.Errorf("Test %v: Expected address %s but found: %s", i, test.addr, m.Addr)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestSetupBasic(t *testing.T) {
 | |
| 	c := caddy.NewTestController("dns", "prometheus localhost:9153")
 | |
| 	if err := setup(c); err != nil {
 | |
| 		t.Fatalf("setup returned error: %v", err)
 | |
| 	}
 | |
| }
 |