mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-31 18:23:13 -04:00 
			
		
		
		
	The coredns/caddy lexer replaces invalid UTF‑8 bytes in tokens with U+FFFD. When that lossy-decoded value is used as `dbfile` in the sign plugin, the source zone file path never exists. On startup/refresh, the `resign()` function sees the signed file missing and triggers signing. Consequently `Sign()` then fails opening the bogus path, the signed file is never created, and the cycle repeats across all expanded origins (e.g., reverse CIDRs), causing unbounded churn/OOM. Validate `dbfile` in setup and error if it contains U+FFFD. Add a regression test. Note: Unicode paths are supported; only U+FFFD (replacement-rune) is rejected. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
		
			
				
	
	
		
			107 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			107 lines
		
	
	
		
			2.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package sign
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"math/rand"
 | |
| 	"path/filepath"
 | |
| 	"strings"
 | |
| 	"time"
 | |
| 
 | |
| 	"github.com/coredns/caddy"
 | |
| 	"github.com/coredns/coredns/core/dnsserver"
 | |
| 	"github.com/coredns/coredns/plugin"
 | |
| )
 | |
| 
 | |
| func init() { plugin.Register("sign", setup) }
 | |
| 
 | |
| func setup(c *caddy.Controller) error {
 | |
| 	sign, err := parse(c)
 | |
| 	if err != nil {
 | |
| 		return plugin.Error("sign", err)
 | |
| 	}
 | |
| 
 | |
| 	c.OnStartup(sign.OnStartup)
 | |
| 	c.OnStartup(func() error {
 | |
| 		for _, signer := range sign.signers {
 | |
| 			go signer.refresh(durationRefreshHours)
 | |
| 		}
 | |
| 		return nil
 | |
| 	})
 | |
| 	c.OnShutdown(func() error {
 | |
| 		for _, signer := range sign.signers {
 | |
| 			close(signer.stop)
 | |
| 		}
 | |
| 		return nil
 | |
| 	})
 | |
| 
 | |
| 	// Don't call AddPlugin, *sign* is not a plugin.
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| func parse(c *caddy.Controller) (*Sign, error) {
 | |
| 	sign := &Sign{}
 | |
| 	config := dnsserver.GetConfig(c)
 | |
| 
 | |
| 	for c.Next() {
 | |
| 		if !c.NextArg() {
 | |
| 			return nil, c.ArgErr()
 | |
| 		}
 | |
| 		dbfile := c.Val()
 | |
| 		if !filepath.IsAbs(dbfile) && config.Root != "" {
 | |
| 			dbfile = filepath.Join(config.Root, dbfile)
 | |
| 		}
 | |
| 
 | |
| 		// Validate dbfile token to avoid infinite signing loops caused by invalid paths
 | |
| 		if strings.ContainsRune(dbfile, '\uFFFD') {
 | |
| 			return nil, fmt.Errorf("dbfile %q contains invalid characters", dbfile)
 | |
| 		}
 | |
| 
 | |
| 		origins := plugin.OriginsFromArgsOrServerBlock(c.RemainingArgs(), c.ServerBlockKeys)
 | |
| 		signers := make([]*Signer, len(origins))
 | |
| 		for i := range origins {
 | |
| 			signers[i] = &Signer{
 | |
| 				dbfile:      dbfile,
 | |
| 				origin:      origins[i],
 | |
| 				jitterIncep: time.Duration(float32(durationInceptionJitter) * rand.Float32()),
 | |
| 				jitterExpir: time.Duration(float32(durationExpirationDayJitter) * rand.Float32()),
 | |
| 				directory:   "/var/lib/coredns",
 | |
| 				stop:        make(chan struct{}),
 | |
| 				signedfile:  fmt.Sprintf("db.%ssigned", origins[i]), // origins[i] is a fqdn, so it ends with a dot, hence %ssigned.
 | |
| 			}
 | |
| 		}
 | |
| 
 | |
| 		for c.NextBlock() {
 | |
| 			switch c.Val() {
 | |
| 			case "key":
 | |
| 				pairs, err := keyParse(c)
 | |
| 				if err != nil {
 | |
| 					return sign, err
 | |
| 				}
 | |
| 				for i := range signers {
 | |
| 					for _, p := range pairs {
 | |
| 						p.Public.Header().Name = signers[i].origin
 | |
| 					}
 | |
| 					signers[i].keys = append(signers[i].keys, pairs...)
 | |
| 				}
 | |
| 			case "directory":
 | |
| 				dir := c.RemainingArgs()
 | |
| 				if len(dir) == 0 || len(dir) > 1 {
 | |
| 					return sign, fmt.Errorf("can only be one argument after %q", "directory")
 | |
| 				}
 | |
| 				if !filepath.IsAbs(dir[0]) && config.Root != "" {
 | |
| 					dir[0] = filepath.Join(config.Root, dir[0])
 | |
| 				}
 | |
| 				for i := range signers {
 | |
| 					signers[i].directory = dir[0]
 | |
| 					signers[i].signedfile = fmt.Sprintf("db.%ssigned", signers[i].origin)
 | |
| 				}
 | |
| 			default:
 | |
| 				return nil, c.Errf("unknown property '%s'", c.Val())
 | |
| 			}
 | |
| 		}
 | |
| 		sign.signers = append(sign.signers, signers...)
 | |
| 	}
 | |
| 
 | |
| 	return sign, nil
 | |
| }
 |