mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-31 10:13:14 -04:00 
			
		
		
		
	* middleware/file: don't reload zone when SOA isn't changed Give Parse an extra argument which is the SOA's serial, if > 0 we check against the just parsed SOA and then just return. Most notable use is in reload.go which is both used in the file and auto middleware. Fixes #415 * PR comments
		
			
				
	
	
		
			162 lines
		
	
	
		
			4.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			162 lines
		
	
	
		
			4.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package file
 | |
| 
 | |
| import (
 | |
| 	"sort"
 | |
| 	"strings"
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/coredns/coredns/middleware/pkg/dnsrecorder"
 | |
| 	"github.com/coredns/coredns/middleware/proxy"
 | |
| 	"github.com/coredns/coredns/middleware/test"
 | |
| 
 | |
| 	"github.com/miekg/dns"
 | |
| 	"golang.org/x/net/context"
 | |
| )
 | |
| 
 | |
| func TestLookupCNAMEChain(t *testing.T) {
 | |
| 	name := "example.org."
 | |
| 	zone, err := Parse(strings.NewReader(dbExampleCNAME), name, "stdin", 0)
 | |
| 	if err != nil {
 | |
| 		t.Fatalf("Expected no error when reading zone, got %q", err)
 | |
| 	}
 | |
| 
 | |
| 	fm := File{Next: test.ErrorHandler(), Zones: Zones{Z: map[string]*Zone{name: zone}, Names: []string{name}}}
 | |
| 	ctx := context.TODO()
 | |
| 
 | |
| 	for _, tc := range cnameTestCases {
 | |
| 		m := tc.Msg()
 | |
| 
 | |
| 		rec := dnsrecorder.New(&test.ResponseWriter{})
 | |
| 		_, err := fm.ServeDNS(ctx, rec, m)
 | |
| 		if err != nil {
 | |
| 			t.Errorf("Expected no error, got %v\n", err)
 | |
| 			return
 | |
| 		}
 | |
| 
 | |
| 		resp := rec.Msg
 | |
| 		sort.Sort(test.RRSet(resp.Answer))
 | |
| 		sort.Sort(test.RRSet(resp.Ns))
 | |
| 		sort.Sort(test.RRSet(resp.Extra))
 | |
| 
 | |
| 		if !test.Header(t, tc, resp) {
 | |
| 			t.Logf("%v\n", resp)
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		if !test.Section(t, tc, test.Answer, resp.Answer) {
 | |
| 			t.Logf("%v\n", resp)
 | |
| 		}
 | |
| 		if !test.Section(t, tc, test.Ns, resp.Ns) {
 | |
| 			t.Logf("%v\n", resp)
 | |
| 
 | |
| 		}
 | |
| 		if !test.Section(t, tc, test.Extra, resp.Extra) {
 | |
| 			t.Logf("%v\n", resp)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| var cnameTestCases = []test.Case{
 | |
| 	{
 | |
| 		Qname: "a.example.org.", Qtype: dns.TypeA,
 | |
| 		Answer: []dns.RR{
 | |
| 			test.A("a.example.org. 1800	IN	A 127.0.0.1"),
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		Qname: "www3.example.org.", Qtype: dns.TypeCNAME,
 | |
| 		Answer: []dns.RR{
 | |
| 			test.CNAME("www3.example.org. 1800	IN	CNAME www2.example.org."),
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		Qname: "dangling.example.org.", Qtype: dns.TypeA,
 | |
| 		Answer: []dns.RR{
 | |
| 			test.CNAME("dangling.example.org. 1800	IN	CNAME foo.example.org."),
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		Qname: "www3.example.org.", Qtype: dns.TypeA,
 | |
| 		Answer: []dns.RR{
 | |
| 			test.A("a.example.org. 1800	IN	A 127.0.0.1"),
 | |
| 			test.CNAME("www.example.org. 1800	IN	CNAME a.example.org."),
 | |
| 			test.CNAME("www1.example.org. 1800	IN	CNAME www.example.org."),
 | |
| 			test.CNAME("www2.example.org. 1800	IN	CNAME www1.example.org."),
 | |
| 			test.CNAME("www3.example.org. 1800	IN	CNAME www2.example.org."),
 | |
| 		},
 | |
| 	},
 | |
| }
 | |
| 
 | |
| func TestLookupCNAMEExternal(t *testing.T) {
 | |
| 	name := "example.org."
 | |
| 	zone, err := Parse(strings.NewReader(dbExampleCNAME), name, "stdin", 0)
 | |
| 	if err != nil {
 | |
| 		t.Fatalf("Expected no error when reading zone, got %q", err)
 | |
| 	}
 | |
| 	zone.Proxy = proxy.NewLookup([]string{"8.8.8.8:53"}) // TODO(miek): point to local instance
 | |
| 
 | |
| 	fm := File{Next: test.ErrorHandler(), Zones: Zones{Z: map[string]*Zone{name: zone}, Names: []string{name}}}
 | |
| 	ctx := context.TODO()
 | |
| 
 | |
| 	for _, tc := range exernalTestCases {
 | |
| 		m := tc.Msg()
 | |
| 
 | |
| 		rec := dnsrecorder.New(&test.ResponseWriter{})
 | |
| 		_, err := fm.ServeDNS(ctx, rec, m)
 | |
| 		if err != nil {
 | |
| 			t.Errorf("Expected no error, got %v\n", err)
 | |
| 			return
 | |
| 		}
 | |
| 
 | |
| 		resp := rec.Msg
 | |
| 		sort.Sort(test.RRSet(resp.Answer))
 | |
| 		sort.Sort(test.RRSet(resp.Ns))
 | |
| 		sort.Sort(test.RRSet(resp.Extra))
 | |
| 
 | |
| 		if !test.Header(t, tc, resp) {
 | |
| 			t.Logf("%v\n", resp)
 | |
| 			continue
 | |
| 		}
 | |
| 
 | |
| 		if !test.Section(t, tc, test.Answer, resp.Answer) {
 | |
| 			t.Logf("%v\n", resp)
 | |
| 		}
 | |
| 		if !test.Section(t, tc, test.Ns, resp.Ns) {
 | |
| 			t.Logf("%v\n", resp)
 | |
| 
 | |
| 		}
 | |
| 		if !test.Section(t, tc, test.Extra, resp.Extra) {
 | |
| 			t.Logf("%v\n", resp)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| var exernalTestCases = []test.Case{
 | |
| 	{
 | |
| 		Qname: "external.example.org.", Qtype: dns.TypeA,
 | |
| 		Answer: []dns.RR{
 | |
| 			test.CNAME("external.example.org. 1800	CNAME	www.example.net."),
 | |
| 			// magic 303 TTL that says: don't check TTL.
 | |
| 			test.A("www.example.net.	303	IN	A	93.184.216.34"),
 | |
| 		},
 | |
| 	},
 | |
| }
 | |
| 
 | |
| const dbExampleCNAME = `
 | |
| $TTL    30M
 | |
| $ORIGIN example.org.
 | |
| @       IN      SOA     linode.atoom.net. miek.miek.nl. (
 | |
|                              1282630057 ; Serial
 | |
|                              4H         ; Refresh
 | |
|                              1H         ; Retry
 | |
|                              7D         ; Expire
 | |
|                              4H )       ; Negative Cache TTL
 | |
| 
 | |
| a               IN      A       127.0.0.1
 | |
| www3            IN      CNAME   www2
 | |
| www2            IN      CNAME   www1
 | |
| www1            IN      CNAME   www
 | |
| www             IN      CNAME   a
 | |
| dangling        IN      CNAME   foo
 | |
| external        IN      CNAME   www.example.net.`
 |