mirror of
https://github.com/coredns/coredns.git
synced 2025-10-27 08:14:18 -04:00
* plugin/health: remove ability to poll other plugins This mechanism defeats the purpose any plugin (mostly) caching can still be alive, we can probably forward queries still. Don't poll plugins, just tell the world we're up and running. It was only actually used in kubernetes; and there specifically would mean any network hiccup would NACK the entire server health. Fixes: #2534 Signed-off-by: Miek Gieben <miek@miek.nl> * update docs based on feedback Signed-off-by: Miek Gieben <miek@miek.nl>
79 lines
1.4 KiB
Go
79 lines
1.4 KiB
Go
package health
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
"time"
|
|
|
|
"github.com/coredns/coredns/plugin"
|
|
"github.com/coredns/coredns/plugin/metrics"
|
|
|
|
"github.com/mholt/caddy"
|
|
)
|
|
|
|
func init() {
|
|
caddy.RegisterPlugin("health", caddy.Plugin{
|
|
ServerType: "dns",
|
|
Action: setup,
|
|
})
|
|
}
|
|
|
|
func setup(c *caddy.Controller) error {
|
|
addr, lame, err := healthParse(c)
|
|
if err != nil {
|
|
return plugin.Error("health", err)
|
|
}
|
|
|
|
h := newHealth(addr)
|
|
h.lameduck = lame
|
|
|
|
c.OnStartup(func() error {
|
|
metrics.MustRegister(c, HealthDuration)
|
|
return nil
|
|
})
|
|
|
|
c.OnStartup(h.OnStartup)
|
|
c.OnRestart(h.OnRestart)
|
|
c.OnFinalShutdown(h.OnFinalShutdown)
|
|
|
|
// Don't do AddPlugin, as health is not *really* a plugin just a separate webserver running.
|
|
return nil
|
|
}
|
|
|
|
func healthParse(c *caddy.Controller) (string, time.Duration, error) {
|
|
addr := ""
|
|
dur := time.Duration(0)
|
|
for c.Next() {
|
|
args := c.RemainingArgs()
|
|
|
|
switch len(args) {
|
|
case 0:
|
|
case 1:
|
|
addr = args[0]
|
|
if _, _, e := net.SplitHostPort(addr); e != nil {
|
|
return "", 0, e
|
|
}
|
|
default:
|
|
return "", 0, c.ArgErr()
|
|
}
|
|
|
|
for c.NextBlock() {
|
|
switch c.Val() {
|
|
case "lameduck":
|
|
args := c.RemainingArgs()
|
|
if len(args) != 1 {
|
|
return "", 0, c.ArgErr()
|
|
}
|
|
l, err := time.ParseDuration(args[0])
|
|
if err != nil {
|
|
return "", 0, fmt.Errorf("unable to parse lameduck duration value: '%v' : %v", args[0], err)
|
|
}
|
|
dur = l
|
|
default:
|
|
return "", 0, c.ArgErr()
|
|
}
|
|
}
|
|
}
|
|
return addr, dur, nil
|
|
}
|