mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-31 10:13:14 -04:00 
			
		
		
		
	* Clean up tests logging This cleans up the travis logs so you can see the failures better. Older tests in tests/ would call log.SetOutput(ioutil.Discard) in a haphazard way. This add log.Discard and put an `init` function in each package's dir (no way to do this globally). The cleanup in tests/ is clear. All plugins also got this init function to have some uniformity and kill any (future) logging there in the tests as well. There is a one-off in pkg/healthcheck because that does log. Signed-off-by: Miek Gieben <miek@miek.nl> * bring back original log_test.go Signed-off-by: Miek Gieben <miek@miek.nl> * suppress logging here as well Signed-off-by: Miek Gieben <miek@miek.nl>
		
			
				
	
	
		
			62 lines
		
	
	
		
			1.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			62 lines
		
	
	
		
			1.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package test
 | |
| 
 | |
| import (
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/coredns/coredns/plugin/proxy"
 | |
| 	mtest "github.com/coredns/coredns/plugin/test"
 | |
| 	"github.com/coredns/coredns/request"
 | |
| 
 | |
| 	"github.com/miekg/dns"
 | |
| )
 | |
| 
 | |
| // Using miek.nl here because this is the easiest zone to get access to and it's masters
 | |
| // run both NSD and BIND9, making checks like "what should we actually return" super easy.
 | |
| var dsTestCases = []mtest.Case{
 | |
| 	{
 | |
| 		Qname: "_udp.miek.nl.", Qtype: dns.TypeDS,
 | |
| 		Rcode: dns.RcodeNameError,
 | |
| 		Ns: []dns.RR{
 | |
| 			mtest.SOA("miek.nl.	1800	IN	SOA	linode.atoom.net. miek.miek.nl. 1282630057 14400 3600 604800 14400"),
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		Qname: "miek.nl.", Qtype: dns.TypeDS,
 | |
| 		Ns: []dns.RR{
 | |
| 			mtest.SOA("miek.nl.	1800	IN	SOA	linode.atoom.net. miek.miek.nl. 1282630057 14400 3600 604800 14400"),
 | |
| 		},
 | |
| 	},
 | |
| }
 | |
| 
 | |
| func TestLookupDS(t *testing.T) {
 | |
| 	t.Parallel()
 | |
| 	name, rm, err := TempFile(".", miekNL)
 | |
| 	if err != nil {
 | |
| 		t.Fatalf("Failed to create zone: %s", err)
 | |
| 	}
 | |
| 	defer rm()
 | |
| 
 | |
| 	corefile := `miek.nl:0 {
 | |
|        file ` + name + `
 | |
| }
 | |
| `
 | |
| 
 | |
| 	i, udp, _, err := CoreDNSServerAndPorts(corefile)
 | |
| 	if err != nil {
 | |
| 		t.Fatalf("Could not get CoreDNS serving instance: %s", err)
 | |
| 	}
 | |
| 	defer i.Stop()
 | |
| 
 | |
| 	p := proxy.NewLookup([]string{udp})
 | |
| 	state := request.Request{W: &mtest.ResponseWriter{}, Req: new(dns.Msg)}
 | |
| 
 | |
| 	for _, tc := range dsTestCases {
 | |
| 		resp, err := p.Lookup(state, tc.Qname, tc.Qtype)
 | |
| 		if err != nil || resp == nil {
 | |
| 			t.Fatalf("Expected to receive reply, but didn't for %s %d", tc.Qname, tc.Qtype)
 | |
| 		}
 | |
| 
 | |
| 		mtest.SortAndCheck(t, resp, tc)
 | |
| 	}
 | |
| }
 |